Closed Bug 1453214 Opened 8 years ago Closed 4 years ago

Intermittent devtools/client/inspector/test/browser_inspector_highlighter-cssshape_04.js | Circle center successfully moved -

Categories

(DevTools :: Inspector, defect, P5)

Product:
DevTools
Component:
Inspector
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED DUPLICATE of bug 1767668

People

(Reporter: intermittent-bug-filer, Unassigned)

References

(Depends on 1 open bug)

Details

(Keywords: intermittent-failure, Whiteboard: [stockwell disabled])

Attachments

(1 file, 2 obsolete files)

Skipped test on linux
937 bytes, patch
jmaher
: review+
Details | Diff | Splinter Review
Product: Firefox → DevTools
This intermittent used to be failing quite rarely, but started to spike quite impressively over the past 4 days. Apparently on windows and linux debug mostly. Razvan, any idea why that would be?
Flags: needinfo?(rcaliman)
Priority: P5 → P2
Attached patch disable_bug_1453214 (obsolete) — — Splinter Review
Attachment #9016927 - Flags: review?(jmaher)
Attachment #9016927 - Flags: review?(jmaher) → review+
Keywords: checkin-needed, leave-open
Whiteboard: [stockwell disable-recommended] → [stockwell disabled]
Pushed by dluca@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/c86bcd5caf4d Disable Bug 1453214 for frequent failures on windows and linux64 r=jmaher
Keywords: checkin-needed
There are 60 failures in the last 7 days. They occur on 56 linux32 (opt) 3 osx-10-10 (opt) 1 macosx64-nightly (opt) Recent failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=207472885&repo=mozilla-inbound&lineNumber=2808 jmaher: I see that this was disabled on linux64. Should it be disabled on linux32 as well? Thank you!
Flags: needinfo?(jmaher)
:ebalazs_ please go ahead and disable on linux32, basically os == linux :)
Flags: needinfo?(jmaher)
Attached patch Skipped test on linux — — Splinter Review
Attachment #9016927 - Attachment is obsolete: true
Attachment #9019665 - Attachment is obsolete: true
Attachment #9019665 - Flags: review?(jmaher)
Attachment #9019666 - Flags: review?(jmaher)
Assignee: ebalazs → nobody
Attachment #9019666 - Flags: review?(jmaher) → review+
Pushed by ebalazs@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/547f834561c3 Disable browser_inspector_highlighter-cssshape_04.js on linux. r=jmaher
Keywords: checkin-needed
Looking at the screenshot in one of the test failures: https://taskcluster-artifacts.net/F9tJCH63QVGsaPVVb6r6fw/0/public/test_info/mozilla-test-fail-screenshot_ixiDkC.png This is very odd. The #circle element is selected, but instead of seeing a circle clip-path value in the CSS rules-view, there's a polygon instead. Also the property has a green bar next to it meaning that the rules-view thinks the property was edited. I'm thinking perhaps the test does not wait for the right events, and selects the #circle element too fast, before the shape path editor has finished editing the previous shape, and therefore the CSS rules for #circle gets edited to a polygon. Unfortunately, I did not manage to make this test fail locally, but I'm fairly certain it's a timing problem, and we need to make the test wait a bit more during each action. For now, it waits for the ruleview-changed event, maybe it should also wait for something else.
I've looked more at this today. We indeed aren't waiting for the right events in this test. Whenever a shape is changed in the page, it results in several different events being fired, some of them fired twice. For instance, property-value-updated is fired twice. I have not been able to understand why that is (this event is normally triggered after a shape is changed, and I was able to confirm that this happened only once), but the fact is that because it does, we need the test to wait for these 2 events every time it changes a shape. Otherwise we run the risk of some unwanted code running after the test has moved on to doing other things. And that probably explains this intermittent. So I would advise surrounding the shape editing code with: // Have to wait for 2 of these events. const onPropertyValueUpdated = waitForNEvents(view, "property-value-updated", 2); ... simulate the various mouse events here ... await onPropertyValueUpdated; I don't have time to create a patch for this, but someone should because this test fails very frequently, and then push to try with many retriggers to see if things work better.
Flags: needinfo?(rcaliman)
Priority: P2 → P5

This is failing constantly on macosx1014-64 debug. https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?startday=2019-09-16&endday=2019-10-16&tree=trunk&bug=1453214
Patrick, you've worked in the past on this, could you take a look over what's going on here? Thanks.

Flags: needinfo?(pbrosset)

It's already disabled on linux and on window debug. So if it starts to fail on mac debug too now, we better look into it.
Razvan, can you make sense of this failure? Maybe comment 44 helps.

Flags: needinfo?(pbrosset) → needinfo?(rcaliman)

The Shapes highlighter tests are too concentrated do too much. I opened bug 1603066 to refactor them to reduce each test's scope so it's easier to reason about failures.

I will keep this NI open as a reminder.

There are 27 total failures in the last 7 days.

debug: macosx1014-64

Recent failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=281849868&repo=autoland&lineNumber=7269

[task 2019-12-19T03:21:27.955Z] 03:21:27 INFO - TEST-PASS | devtools/client/inspector/test/browser_inspector_highlighter-cssshape_04.js | Point successfully removed -
[task 2019-12-19T03:21:27.955Z] 03:21:27 INFO - Buffered messages logged at 03:21:27
[task 2019-12-19T03:21:27.955Z] 03:21:27 INFO - Turn off shapes highlighter for #polygon
[task 2019-12-19T03:21:27.955Z] 03:21:27 INFO - Toggle shapes highlighter off for clip-path on #polygon
[task 2019-12-19T03:21:27.956Z] 03:21:27 INFO - Turn on shapes highlighter for #circle
[task 2019-12-19T03:21:27.956Z] 03:21:27 INFO - Selecting the node for '#circle'
[task 2019-12-19T03:21:27.956Z] 03:21:27 INFO - Toggle shapes highlighter on for clip-path on #circle
[task 2019-12-19T03:21:27.956Z] 03:21:27 INFO - Moving circle center
[task 2019-12-19T03:21:27.956Z] 03:21:27 INFO - Waiting for shape changes to apply
[task 2019-12-19T03:21:27.956Z] 03:21:27 INFO - Buffered messages finished
[task 2019-12-19T03:21:27.957Z] 03:21:27 INFO - TEST-UNEXPECTED-FAIL | devtools/client/inspector/test/browser_inspector_highlighter-cssshape_04.js | Circle center successfully moved -
[task 2019-12-19T03:21:27.957Z] 03:21:27 INFO - Stack trace:
[task 2019-12-19T03:21:27.957Z] 03:21:27 INFO - chrome://mochikit/content/browser-test.js:test_ok:1292
[task 2019-12-19T03:21:27.957Z] 03:21:27 INFO - chrome://mochitests/content/browser/devtools/client/inspector/test/browser_inspector_highlighter-cssshape_04.js:testCircleMoveCenter:259
[task 2019-12-19T03:21:27.957Z] 03:21:27 INFO - chrome://mochitests/content/browser/devtools/client/inspector/test/browser_inspector_highlighter-cssshape_04.js:null:24
[task 2019-12-19T03:21:27.957Z] 03:21:27 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1062
[task 2019-12-19T03:21:27.957Z] 03:21:27 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1097
[task 2019-12-19T03:21:27.957Z] 03:21:27 INFO - chrome://mochikit/content/browser-test.js:nextTest/<:925
[task 2019-12-19T03:21:27.957Z] 03:21:27 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:808
[task 2019-12-19T03:21:27.957Z] 03:21:27 INFO - Turn off shapes highlighter for #circle
[task 2019-12-19T03:21:27.957Z] 03:21:27 INFO - Toggle shapes highlighter off for clip-path on #circle
[task 2019-12-19T03:21:27.958Z] 03:21:27 INFO - GECKO(1786) | [Child 1791: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 5 (0x147213000) [pid = 1791] [serial = 65] [outer = 0x0] [url = http://example.com/browser/devtools/client/inspector/test/doc_inspector_highlighter_cssshapes.html]
[task 2019-12-19T03:21:27.958Z] 03:21:27 INFO - Turn on shapes highlighter for #ellipse
[task 2019-12-19T03:21:27.958Z] 03:21:27 INFO - Selecting the node for '#ellipse'
[task 2019-12-19T03:21:27.958Z] 03:21:27 INFO - GECKO(1786) | [Child 1791: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 0x11113c000 == 1 [pid = 1791] [id = {e197b56f-cc13-174f-8373-cb23a52ed003}] [url = http://example.com/browser/devtools/client/inspector/test/doc_inspector_highlighter_cssshapes.html]
[task 2019-12-19T03:21:28.065Z] 03:21:28 INFO - Toggle shapes highlighter on for clip-path on #ellipse
[task 2019-12-19T03:21:28.100Z] 03:21:28 INFO - GECKO(1786) | console.log: "[DISPATCH] action type:" "CLEAR_FLEXBOX"
[task 2019-12-19T03:21:28.212Z] 03:21:28 INFO - GECKO(1786) | console.log: "[DISPATCH] action type:" "UPDATE_OFFSET_PARENT"
[task 2019-12-19T03:21:28.213Z] 03:21:28 INFO - GECKO(1786) | console.log: "[DISPATCH] action type:" "UPDATE_LAYOUT"
[task 2019-12-19T03:21:28.300Z] 03:21:28 INFO - Moving ellipse rx
[task 2019-12-19T03:21:28.450Z] 03:21:28 INFO - GECKO(1786) | console.log: "[DISPATCH] action type:" "CLEAR_FLEXBOX"
[task 2019-12-19T03:21:28.500Z] 03:21:28 INFO - Moving ellipse ry
[task 2019-12-19T03:21:28.500Z] 03:21:28 INFO - GECKO(1786) | console.log: "[DISPATCH] action type:" "UPDATE_OFFSET_PARENT"
[task 2019-12-19T03:21:28.502Z] 03:21:28 INFO - GECKO(1786) | console.log: "[DISPATCH] action type:" "UPDATE_LAYOUT"
[task 2019-12-19T03:21:28.837Z] 03:21:28 INFO - GECKO(1786) | console.log: "[DISPATCH] action type:" "UPDATE_OFFSET_PARENT"
[task 2019-12-19T03:21:28.864Z] 03:21:28 INFO - GECKO(1786) | console.log: "[DISPATCH] action type:" "UPDATE_LAYOUT"
[task 2019-12-19T03:21:29.046Z] 03:21:29 INFO - GECKO(1786) | console.log: "[DISPATCH] action type:" "CLEAR_FLEXBOX"
[task 2019-12-19T03:21:29.100Z] 03:21:29 INFO - TEST-PASS | devtools/client/inspector/test/browser_inspector_highlighter-cssshape_04.js | Ellipse radiuses successfully moved

Update:
There have been 25 failures within the last 7 days:

  • 8 failures on Windows 10 x64 CCov opt
  • 17 failures on OS X 10.14 debug

Recent failure: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=287084087&repo=autoland&lineNumber=5426

Gabriel,
Could you please redirect this to someone who can take a look?

Flags: needinfo?(gl)

Seems like Razvan should already be on it.

Flags: needinfo?(gl)

We'll update all Shape Editor tests when we migrate the tool to support Fission in bug 1572663.

Depends on: 1572663
Flags: needinfo?(rcaliman)

Bug 1750834 is going to disable this on OSX debug. It looks like that already has a high failure rate. This test is also already disabled on Linux (opt and debug) and Windows (debug and ASan), leaving OSX/Windows opt as the main remaining place it will be getting run.

Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: