1453266 - taskgraph: Make ship-it tasks support esr60

Status: RESOLVED FIXED

(Release Engineering :: Release Automation: Other, enhancement)

Description

[Johan Lorenzo [:jlorenzo]]

Generating a taskgraph with esr60 configs[1] leads to some discrepancies. The things I've noticed are:

* release-mark-as-shipped-firefox
  * Bad version name. This might be caused by bug 1453261 comment 1
  * bad worker type
  * bad scope "project:releng:shipit:staging"

There are probably other issues I didn't see.

[1] https://bugzilla.mozilla.org/show_bug.cgi?id=1434889#c4

Comment 1

[Johan Lorenzo [:jlorenzo]]

NI'ing myself to fix this, as I worked on the original task def.

Comment 2

[Johan Lorenzo [:jlorenzo]]

(In reply to Johan Lorenzo [:jlorenzo] from comment #0)
> * release-mark-as-shipped-firefox
>   * Bad version name. This might be caused by bug 1453261 comment 1

With the correct data discussed in bug 1453261 comment 4, the release_name in the payload is now correct: "Firefox-60.0esr-build1"

Comment 3

[Johan Lorenzo [:jlorenzo]]

Attachment: Bug 1453266 - Fix bad worker-type and scopes

Review commit: https://reviewboard.mozilla.org/r/236856/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/236856/

Comment 4

[Rail Aliiev [:rail]]

Comment on attachment 8968183 [details]
Bug 1453266 - Fix bad worker-type and scopes

https://reviewboard.mozilla.org/r/236856/#review242642

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4cc04fbbd1d7
Fix bad worker-type and scopes r=rail

Comment 6

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/4cc04fbbd1d7

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr60/rev/3fb937cd6d84