Closed
Bug 1453285
Opened 8 years ago
Closed 7 years ago
pdfium non-portable shell script
Categories
(Firefox :: PDF Viewer, defect)
Firefox
PDF Viewer
Tracking
()
RESOLVED
INVALID
People
(Reporter: coypu, Unassigned)
Details
Attachments
(1 file)
|
908 bytes,
patch
|
jwatt
:
review+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (X11; NetBSD amd64; rv:59.0) Gecko/20100101 Firefox/59.0
Build ID: 20180410163343
Steps to reproduce:
Package manager has a script to detect this in scripts.
The script will complain until it's fixed.
Here is the fix.
= is for POSIX (i.e. all shells)
== is for bash
Attachment #8966939 -
Flags: review+
Attachment #8966939 -
Flags: review+ → review?(tom)
|
||
Updated•8 years ago
|
Attachment #8966939 -
Flags: review?(tom) → review?(jwatt)
|
||
Comment 1•7 years ago
|
||
Comment on attachment 8966939 [details] [diff] [review]
0001-Fix-non-portable-test-1.patch
Thanks, although we have no plans to ship PDFium any more, so I'm curious how you came to bump into this issue.
Attachment #8966939 -
Flags: review?(jwatt) → review+
|
||
Updated•7 years ago
|
Component: Untriaged → PDF Viewer
|
|
||
Updated•7 years ago
|
Status: UNCONFIRMED → RESOLVED
Closed: 7 years ago
Resolution: --- → INVALID
You need to log in
before you can comment on or make changes to this bug.
Description
•