145336 - Cards with only an email address don't always sync

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Address Book & Contacts, defect)

Description

[Cavin Song]

This is the mozilla version of bugscape #15558. Comments from original bug:

Branch build 2002-05-12-20-07pr1: WinMe
(Olga and Esther also observed a similar problem)

Overview: After syncing the cards which only have an email address did not sync
the first time.

Steps to reproduce:
1. In my case I start with Netscape 6.1 and created a list where some of the
entries did not have an existing card. In these cases a new card appears with
only an email addres (i.e. [e-mail])
2. Upgraded to the latest build
3. Opened Mail, logged into all accounts
4. Opened Address Book and synced. 

Actual Results: All entries were synced except the one that only had an email
address ([e-mail])
Workaround: I created a new entry in my Personal Address Book with only an email
address and it synced the new entry but not the original card that had the 
problem. 

Expected Results: It should sync all entries.



------- Additional Comment #1 From Ninoschka Baca 2002-05-13 19:35 -------

Tried again but this time:
Installed 6.1, added two more cards with only an email address
([e-mail] and [e-mail]). Upgraded to the 5/12n7pr1
build, synced:

Actual Results: [e-mail] and [e-mail] did sync but the
original card is still having a problem of not syncing ([e-mail]).
I must have done something special to create this card.

Will need to investigate further.

Adding Olga and Esther to the Cc list if they have any more information.



------- Additional Comment #2 From Ninoschka Baca 2002-05-13 19:43 -------

ok, I think I found an easy way to reproduce the problem:

1. Select New List
2. Type the name of the list and then add addresses that do not have
corresponding cards (In my case I added [e-mail] and [e-mail] to
the list). 
3. Select the New Card button and just enter an email address ([e-mail])
and press OK. 
4. Sync

Actual Results:
- The addresses that were entered into the list, initially, are not synced
([e-mail] and [e-mail])
- The card that was created via the New Card button is successful when synced.

Marking nsbeta1 since this could appear as data loss since not all of the
addresses are making it through the sync process to appear in the WebMail
account  via the browser.

------- Additional Comment #6 From Scott Putterman 2002-05-15 09:34 -------

Cavin, are you saying that cards in address books that were created in a mailing
list are marked differently internally than cards created through New Card?  

To the user, though, there isn't any difference, so I'd expect that any card in
my PAB should be synced.



------- Additional Comment #7 From [e-mail] 2002-05-15 09:56 -------

I agree with putterman. If a card is added to AB only because it was added to a 
Mailing list, it is still a valid card entry in the ab and should be synched.



------- Additional Comment #8 From Cavin Song 2002-05-15 10:12 -------

Agree that cards in AB should be synced and I'm looking into the problem why 
they're not synced right now. But should the lists themselves be synced as 
contacts in webmail though? I guess this is a separate issue to address.



------- Additional Comment #9 From Cavin Song 2002-05-15 11:43 -------

> Cavin, are you saying that cards in address books that were created in a
> mailing list are marked differently internally than cards created through New
> Card?
>
It does look like this is the case. When creating cards through New Card we set 
the 'key' field in the db to some positive numbers but it's set to 0 when 
creating cards from lists. Because the 'key' field is 0 the absync code would 
just ignore the cards. I'm looking into why card creation from different paths 
works differently.



------- Additional Comment #10 From Cavin Song 2002-05-15 15:26 -------

OK, we did not create keys for cards created from list members so the absync 
code drops/ignores these cards during synchronization. A patch is coming.



------- Additional Comment #11 From Cavin Song 2002-05-15 15:29 -------

Created an attachment (id=6165)
Proposed patch, v1

In nsAddrDatabase::AddListCardColumnsToRow(), call AddRecordKeyColumnToRow() to
create a key for the new row.



------- Additional Comment #12 From Seth Spitzer 2002-05-15 22:39 -------

sr=sspitzer

I was going to ask "what if the email / card already exists?"

but looking at the surrounding code, we should be ok, as it only executes when
it's a new email.

     //New Email, then add a new row with this email
     err  = GetNewRow(&pCardRow);

     if (NS_SUCCEEDED(err) && pCardRow)
     {
       AddPrimaryEmail(pCardRow, NS_ConvertUCS2toUTF8(email).get());
       err = m_mdbPabTable->AddRow(GetEnv(), pCardRow);
     }



------- Additional Comment #13 From Dan Mosedale 2002-05-17 10:52 -------

(From update of attachment 6165 [details])
r=dmose.

Comment 1

[Cavin Song]

Copying whitboard and keywords from original bug.

Comment 2

[Cavin Song]

Attachment: Proposed patch, v1

Original patch.

Comment 3

[Cavin Song]

Fix landed on trunk.

Comment 4

[scottputterman]

Ninoschka, could you verify this on the trunnk?

Comment 5

[Ninoschka Baca]

Trunk build 2002-05-20-08: WinMe, Mac 10.1.3
Trunk build 2002-05-20-07: Linux RH 7.1
Verified Fixed on the trunk.

In a new profile I created a list and added email addresses. After closing the
list, these addresses appeared as individual cards in the results pane. After a
Sync the name of the list and each card appeard in the WebMail address book via
the browser. 

Comment 6

[Jaime Rodriguez, Jr.]

adt1.0.1+ (on ADT's behalf) for checkin to the 1.0 branch, pending Driver's
approval.

Comment 7

[Judson Valeski]

please checkin to the 1.0.1 branch ASAP. once there, remove the mozilla1.0.1+
keyword and add the fixed1.0.1 keyword.

Comment 8

[Cavin Song]

Fix checked into branch.

Comment 9

[Ninoschka Baca]

Branch 2002-06-11: WinMe, Linux RH 7.1, Mac 10.1.3
verified1.0.1