Closed Bug 1453397 Opened 3 years ago Closed 3 years ago
Reduce unsafe usage of integer->enum casts in IPC
59 bytes, text/x-review-board-request
IME IPC uses |static_cast<Enum>(aArg)| in a handful of places in IPC which are unsafe under an adversarial content process, because it could send values that are outside the range of valid values. I didn't spot any codepaths where this is necessarily exploitable, but there are a lot of them, so better safe than sorry :-)
Jim, wasn't sure who the best reviewer for this would be, can you suggest someone?
Attachment #8967071 - Flags: review?(masayuki)
Removing ni?, discussed on IRC.
Comment on attachment 8967071 [details] Bug 1453397 - use ContiguousEnumSerializer for serialization of enums in IPC for IMEs; https://reviewboard.mozilla.org/r/235728/#review241676
Attachment #8967071 - Flags: review?(masayuki) → review+
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/775374240991 use ContiguousEnumSerializer for serialization of enums in IPC for IMEs; r=masayuki
Component: Event Handling → User events and focus handling
You need to log in before you can comment on or make changes to this bug.