Closed Bug 1453426 Opened 2 years ago Closed 2 years ago

Ctrl-C'ing "mach build" does not pass the signal to the tup process

Categories

(Firefox Build System :: General, enhancement)

3 Branch
enhancement
Not set
normal

Tracking

(firefox61 fixed)

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: mshal, Assigned: chmanchester)

References

Details

Attachments

(1 file)

If you ctrl-C a 'mach build' with the tup backend, mach exits, but the underlying tup process doesn't see the signal and continues to build in the background. I suspect this may be because of the way tup is invoked through make. We should have it kill tup as well. This can possibly be fixed by just invoking tup directly, since I think make is no longer required after bug 1445398.
Comment on attachment 8968703 [details]
Bug 1453426 - Kill invoked process on keyboard interrupt in mach build.

https://reviewboard.mozilla.org/r/237388/#review243410
Attachment #8968703 - Flags: review?(mshal) → review+
Assignee: nobody → cmanchester
Pushed by cmanchester@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6ac1521dcbf9
Kill invoked process on keyboard interrupt in mach build. r=mshal
https://hg.mozilla.org/mozilla-central/rev/6ac1521dcbf9
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Version: Version 3 → 3 Branch
You need to log in before you can comment on or make changes to this bug.