Closed
Bug 1453426
Opened 7 years ago
Closed 7 years ago
Ctrl-C'ing "mach build" does not pass the signal to the tup process
Categories
(Firefox Build System :: General, enhancement)
Tracking
(firefox61 fixed)
RESOLVED
FIXED
mozilla61
Tracking | Status | |
---|---|---|
firefox61 | --- | fixed |
People
(Reporter: mshal, Assigned: chmanchester)
References
Details
Attachments
(1 file)
If you ctrl-C a 'mach build' with the tup backend, mach exits, but the underlying tup process doesn't see the signal and continues to build in the background. I suspect this may be because of the way tup is invoked through make. We should have it kill tup as well. This can possibly be fixed by just invoking tup directly, since I think make is no longer required after bug 1445398.
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Attachment #8968703 -
Flags: review?(mshal)
Reporter | ||
Comment 2•7 years ago
|
||
mozreview-review |
Comment on attachment 8968703 [details]
Bug 1453426 - Kill invoked process on keyboard interrupt in mach build.
https://reviewboard.mozilla.org/r/237388/#review243410
Attachment #8968703 -
Flags: review?(mshal) → review+
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → cmanchester
Pushed by cmanchester@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6ac1521dcbf9
Kill invoked process on keyboard interrupt in mach build. r=mshal
Comment 4•7 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Updated•6 years ago
|
Version: Version 3 → 3 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•