1453472 - Add overscroll-behavior-{block,inline} properties in addition to overscroll-behavior-{x,y}

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement, P3)

Description

[Botond Ballo [:botond]]

In bug 951793, we implemented a new overscroll-behavior property, which has per-axis versions overscroll-behavior-x and overscroll-behavior-y.

A spec change has recently been approved [1] to support logical versions of t hese, overscroll-behavior-block and overscroll-behavior-inline. This bug tracks adding support for these logical properties.

[1] https://github.com/w3c/csswg-drafts/issues/2473

Comment 1

[Botond Ballo [:botond]]

Emilio, might this make a nice mentored bug for a new Stylo contributor?

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Sure, it's a matter of adding two new entries to: servo/components/style/properties/longhand/box.mako.rs

With overscroll-behavior-{block,inline}, and marking them as logical=True. I think that should be all. Either that or maybe a bit of adjustment is needed in helpers.mako.rs to handle them, but that should be about it.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Of course tests need to be added :)

Comment 4

[sahith.reddy]

Hello, I am a new contributor and would like to try this issue. I do not have much grasp on rust so this will be new to me so sorry for any mistakes in advance.

Comment 5

[sahith.reddy]

Hello, I followed some examples in that file mentioned and I added this piece of code:

% for direction in ["block", "inline"]:
    ${helpers.predefined_type(
        "overscroll-behavior-" + direction,
        logical=True
    )}
% endfor

I am not sure how close this is to correct? Anything else I will need to add? (I will try adding tests now)

Comment 6

[Majid Valipour]

FYI, I am about to land and ship this in Blink: https://chromium-review.googlesource.com/c/chromium/src/+/1614026

Comment 7

[Majid Valipour]

Botond, Emilio (or anyone else who is able to): can you confirm if the plan is to implement these logical long-hangs in Gecko at some point.

I have claimed "Public Support" in blink intent to ship for Firefox but is it really the case? I appreciate if you can clarify your intentions here.

Comment 8

[Botond Ballo [:botond]]

As far as I'm aware, we are in support of these logical properties, yes.

In terms of a plan, I don't believe it's on any sort of roadmap, but the bug is marked as mentored so an interested contributor could come along and implement it any time and we would accept it; barring that, Emilio or I will do it as time permits.

Comment 9

[Majid Valipour]

Thank you for the response. That should count as Public Support for Blink. (Insert joke about logical properties being logical)

Comment 10

[Sean Voisen (:svoisen)]

Now that the tests for this are in WPT, there's not much left to do here. I have a patch so I'll take this.

Comment 11

[Sean Voisen (:svoisen)]

Attachment: Bug 1453472 - Add support for logical versions of overscroll-behavior.

Comment 12

[Emilio Cobos Álvarez (:emilio)]

That is the wrong flag. The right way to do it for central is in Phabricator > Edit Revision > Add Tags.

But I guess I'll just land it. Sean, mind sending an intent email for this? Or should I do that?

Comment 13

[Sean Voisen (:svoisen)]

Ah gotcha. See this is why I need to do this from time to time! :)

I'll send the intent.

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8faa0330e8fa
Add support for logical versions of overscroll-behavior. r=emilio

Comment 15

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/8faa0330e8fa

Comment 16

[Chris Mills [:cmills]]

Properties documented by Rachel:

• https://wiki.developer.mozilla.org/en-US/docs/Web/CSS/overscroll-behavior-block
• https://wiki.developer.mozilla.org/en-US/docs/Web/CSS/overscroll-behavior-inline