1453521 - Support prefs for aliases in Servo side

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement)

Description

[Xidorn Quan [:xidorn] UTC+10]

Currently in the Servo side code, aliases inherit prefs from their original property, however we do want separate control of them.

Comment 1

[Xidorn Quan [:xidorn] UTC+10]

Attachment: Bug 1453521 - Support prefs for aliases in Servo side.

Review commit: https://reviewboard.mozilla.org/r/235882/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/235882/

Comment 2

[Cameron McCormack (:heycam)]

Comment on attachment 8967214 [details]
Bug 1453521 - Support prefs for aliases in Servo side.

https://reviewboard.mozilla.org/r/235882/#review242094

::: servo/components/style/properties/data.py:192
(Diff revision 1)
>          self.enabled_in = enabled_in
>          self.need_index = need_index
>          self.gecko_ffi_name = gecko_ffi_name or "m" + self.camel_case
>          self.cast_type = cast_type
>          self.logical = arg_to_bool(logical)
> -        self.alias = alias.split() if alias else []
> +        self.alias = parse_property_aliases(alias)

Nit: Should we rename this to self.aliases, since there can be more than one?  (Or do we want to prevent there being more than one alias?)

Comment 3

[Cameron McCormack (:heycam)]

It would be great if you could add a test for pref-controlled aliases, too.

Comment 4

[Xidorn Quan [:xidorn] UTC+10]

Comment on attachment 8967214 [details]
Bug 1453521 - Support prefs for aliases in Servo side.

https://reviewboard.mozilla.org/r/235882/#review242094

> Nit: Should we rename this to self.aliases, since there can be more than one?  (Or do we want to prevent there being more than one alias?)

We do have multiple aliases for some properties, mostly due to webkit / moz prefixes. We may want to rename it, but since it is an existing issue unrelated to this bug, and renaming it will touch code unrelated to this change, I'd rather landing this patch as is and probably do that in a followup.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5ae98dae0599
Support prefs for aliases in Servo side. r=heycam

Comment 6

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/5ae98dae0599