Support prefs for aliases in Servo side

RESOLVED FIXED in Firefox 61

Status

()

enhancement
RESOLVED FIXED
Last year
Last year

People

(Reporter: xidorn, Assigned: xidorn)

Tracking

Trunk
mozilla61
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox61 fixed)

Details

Attachments

(1 attachment)

Currently in the Servo side code, aliases inherit prefs from their original property, however we do want separate control of them.
Comment on attachment 8967214 [details]
Bug 1453521 - Support prefs for aliases in Servo side.

https://reviewboard.mozilla.org/r/235882/#review242094

::: servo/components/style/properties/data.py:192
(Diff revision 1)
>          self.enabled_in = enabled_in
>          self.need_index = need_index
>          self.gecko_ffi_name = gecko_ffi_name or "m" + self.camel_case
>          self.cast_type = cast_type
>          self.logical = arg_to_bool(logical)
> -        self.alias = alias.split() if alias else []
> +        self.alias = parse_property_aliases(alias)

Nit: Should we rename this to self.aliases, since there can be more than one?  (Or do we want to prevent there being more than one alias?)
Attachment #8967214 - Flags: review?(cam) → review+
It would be great if you could add a test for pref-controlled aliases, too.
Comment on attachment 8967214 [details]
Bug 1453521 - Support prefs for aliases in Servo side.

https://reviewboard.mozilla.org/r/235882/#review242094

> Nit: Should we rename this to self.aliases, since there can be more than one?  (Or do we want to prevent there being more than one alias?)

We do have multiple aliases for some properties, mostly due to webkit / moz prefixes. We may want to rename it, but since it is an existing issue unrelated to this bug, and renaming it will touch code unrelated to this change, I'd rather landing this patch as is and probably do that in a followup.
Pushed by xquan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5ae98dae0599
Support prefs for aliases in Servo side. r=heycam
https://hg.mozilla.org/mozilla-central/rev/5ae98dae0599
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.