Closed
Bug 1453551
Opened 6 years ago
Closed 6 years ago
Don't use i8 as c_char in xpcom-gtest
Categories
(Core :: XPCOM, enhancement)
Tracking
()
RESOLVED
FIXED
mozilla61
| Tracking | Status | |
|---|---|---|
| firefox61 | --- | fixed |
People
(Reporter: m_kato, Assigned: m_kato)
References
Details
Attachments
(1 file)
Since I try compiling gtest on Linux/aarch64 (for aarch64 implementation test of Android), it cannot compile gtest. In gtest, although xpcom-gtest uses CStr::from_ptr(topic) in https://searchfox.org/mozilla-central/rev/4114ad2cfcbc511705c7865a4a34741812f9a2a9/xpcom/rust/gtest/xpcom/test.rs#36, c_char isn't i8 in some platforms such as arm (https://github.com/rust-lang/rust/blob/bd98fe0c05601d8a318a709adc4263f3348ea8d4/src/libstd/os/raw/mod.rs#L45). so we shouldn't use i8 as c_char.
|
Assignee | |
Comment 1•6 years ago
|
||
correct marker is https://github.com/rust-lang/rust/blob/bd98fe0c05601d8a318a709adc4263f3348ea8d4/src/libstd/os/raw/mod.rs#L34 for rust library.
|
|
Assignee | |
Updated•6 years ago
|
Assignee: nobody → m_kato
| Comment hidden (mozreview-request) |
|
||
Comment 3•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8967282 [details] Bug 1453551 - Don't use i8 as c_char in xpcom-gtest. https://reviewboard.mozilla.org/r/235968/#review242794
Attachment #8967282 -
Flags: review?(nika) → review+
Pushed by m_kato@ga2.so-net.ne.jp: https://hg.mozilla.org/integration/autoland/rev/4c40ad65f472 Don't use i8 as c_char in xpcom-gtest. r=mystor
|
||
Comment 5•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/4c40ad65f472
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in
before you can comment on or make changes to this bug.
Description
•