1453577 - "Automation Error" log output should contain name of the test harness

Status: RESOLVED WONTFIX

(Release Engineering :: Applications: MozharnessCore, enhancement)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

(In reply to Chris AtLee [:catlee] from bug 1436237 comment #26)
> > > * Ideally the mozharness error prefix for this line would be ERROR not INFO
> > > (though this doesn't affect the log parser, since it specifically checks for
> > > "Automation Error:", though we want to move away from hardcoding every error
> > > string variation in Treeherder)
> > 
> > Would it help if we make the harness name part of the error line so we have
> > at least an idea about which harness the automation error is about? It could
> > be something like: "Automation Error: mozprocess timed out after 1000
> > seconds running reftest: %command%.
> 
> Yes, that would be much clearer IMO.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

The problem here is that `run_command` doens't know anything about the customer code using it:

https://dxr.mozilla.org/mozilla-central/rev/325ef357e5b73d63794e47c02c7f8e7cf58ccb48/testing/mozharness/mozharness/base/script.py#1400

The only option I see is to add another optional argument, which harnesses could set to get their name added to the error line.

Chris, any feedback from your side?

Comment 2

[Geoff Brown [:gbrown]]

The command is already included in the message, and that sometimes identifies the harness; in other cases, determining the harness/script is relatively simple -- scroll up in the test log.