Response.redirect() should have empty string statusText

RESOLVED FIXED in Firefox 64

Status

()

enhancement
P3
normal
RESOLVED FIXED
a year ago
a month ago

People

(Reporter: annevk, Assigned: dpino)

Tracking

(Blocks 1 bug, {good-first-bug})

unspecified
mozilla64
Points:
---

Firefox Tracking Flags

(firefox64 fixed)

Details

Attachments

(1 attachment, 2 obsolete attachments)

Priority: -- → P3
(Assignee)

Comment 1

7 months ago
Here's a patch. I updated `dom/tests/mochitest/fetch/test_response.js` to check redirect statusText is empty. All tests in `dom/tests/mochitest/fetch/` are passing. I think no more additional changes in other tests are needed.
Attachment #9016775 - Flags: review?(amarchesini)
Attachment #9016775 - Flags: review?(amarchesini) → review+
(Assignee)

Comment 2

7 months ago
Thanks for the quick review. Added r=baku to commit message. Treeherder: https://treeherder.mozilla.org/#/jobs?repo=try&revision=9542a6c54f81c70493391cdd7be45a11f7decfd9
Attachment #9016775 - Attachment is obsolete: true
(Assignee)

Comment 3

7 months ago
Something went wrong with the previous "try". I launched another one for this bug at: https://treeherder.mozilla.org/#/jobs?repo=try&revision=02208ef03bdb3067d2cc14b1768851675d26922e&selectedJob=205244973. Everything seems to be OK.

I cannot commit. I'd need to get the bug assigned so I can edit and add tag "checkin-needed", or somebody to commit for me.

Updated

6 months ago
Assignee: nobody → dpino
(Assignee)

Updated

6 months ago
Keywords: checkin-needed

Comment 4

6 months ago
Pushed by rgurzau@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ec067b17f7d3
Response.redirect() should have empty string statusText. r=baku
Keywords: checkin-needed
Backed out for /fetch/api/response/response-static-redirect.html failures.

backout: https://hg.mozilla.org/integration/mozilla-inbound/rev/00351b000d8835beb11192c939f3953699799940

push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=4afcdb551984b452e41847bc2a2690f46bdbbefe&group_state=expanded&searchStr=wpt

failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=205401800&repo=mozilla-inbound&lineNumber=2308

[task 2018-10-14T21:00:55.904Z] 21:00:55     INFO - TEST-START | /fetch/api/response/response-static-redirect.html
[task 2018-10-14T21:00:56.067Z] 21:00:56     INFO - 
[task 2018-10-14T21:00:56.067Z] 21:00:56     INFO - TEST-UNEXPECTED-PASS | /fetch/api/response/response-static-redirect.html | Check default redirect response - expected FAIL
[task 2018-10-14T21:00:56.067Z] 21:00:56     INFO - TEST-INFO | expected FAIL
[task 2018-10-14T21:00:56.067Z] 21:00:56     INFO - 
[task 2018-10-14T21:00:56.067Z] 21:00:56     INFO - TEST-UNEXPECTED-PASS | /fetch/api/response/response-static-redirect.html | Check response returned by static method redirect(), status = 301 - expected FAIL
[task 2018-10-14T21:00:56.067Z] 21:00:56     INFO - TEST-INFO | expected FAIL
[task 2018-10-14T21:00:56.067Z] 21:00:56     INFO - 
[task 2018-10-14T21:00:56.067Z] 21:00:56     INFO - TEST-UNEXPECTED-PASS | /fetch/api/response/response-static-redirect.html | Check response returned by static method redirect(), status = 302 - expected FAIL
[task 2018-10-14T21:00:56.067Z] 21:00:56     INFO - TEST-INFO | expected FAIL
[task 2018-10-14T21:00:56.067Z] 21:00:56     INFO - 
[task 2018-10-14T21:00:56.067Z] 21:00:56     INFO - TEST-UNEXPECTED-PASS | /fetch/api/response/response-static-redirect.html | Check response returned by static method redirect(), status = 303 - expected FAIL
[task 2018-10-14T21:00:56.067Z] 21:00:56     INFO - TEST-INFO | expected FAIL
[task 2018-10-14T21:00:56.067Z] 21:00:56     INFO - 
[task 2018-10-14T21:00:56.067Z] 21:00:56     INFO - TEST-UNEXPECTED-PASS | /fetch/api/response/response-static-redirect.html | Check response returned by static method redirect(), status = 307 - expected FAIL
[task 2018-10-14T21:00:56.067Z] 21:00:56     INFO - TEST-INFO | expected FAIL
[task 2018-10-14T21:00:56.067Z] 21:00:56     INFO - 
[task 2018-10-14T21:00:56.067Z] 21:00:56     INFO - TEST-UNEXPECTED-PASS | /fetch/api/response/response-static-redirect.html | Check response returned by static method redirect(), status = 308 - expected FAIL
[task 2018-10-14T21:00:56.067Z] 21:00:56     INFO - TEST-INFO | expected FAIL
[task 2018-10-14T21:00:56.067Z] 21:00:56     INFO - .....
[task 2018-10-14T21:00:56.067Z] 21:00:56     INFO - TEST-OK | /fetch/api/response/response-static-redirect.html | took 156ms
Flags: needinfo?(dpino)
(Assignee)

Comment 6

6 months ago
Updated patch. Some web-platform-tests that were expected to fail are now passing, that's why the bot failed and the commit was reverted (it was clear in the try, but I misread it).
Attachment #9016823 - Attachment is obsolete: true
Flags: needinfo?(dpino)
Attachment #9017053 - Flags: review?(amarchesini)
(Assignee)

Updated

6 months ago
Status: NEW → ASSIGNED
Attachment #9017053 - Flags: review?(amarchesini) → review+
(Assignee)

Comment 8

6 months ago
I have some trouble with testing the patch in the try bot. When I send the patch to try, the patch is not included (see treeherder in previous comment). This is what try reports:

$ ./mach try -b o -p all -u mochitests,web-platform-tests -t none
Bundling 2 changesets
Bundling 1 manifests
Bundling 3 files
remote: adding changesets
remote: adding manifests
remote: adding file changes
remote: added 1 changesets with 0 changes to 3 files (+1 heads)

I have my changes in a local git branch:

$ git cherry -v branches/default/tip 
+ d3aa5b829223ec27f12eedf856656b3e8b7d9a15 Bug 1453612 - Response.redirect() should have empty string statusText. r=baku

And these changes correspond to the changes in the attached patch (with the inclusion of `response-static-redirect.html.ini).

$ git show --stat
commit d3aa5b829223ec27f12eedf856656b3e8b7d9a15 (HEAD -> fix-bug-1453612)
Author: Diego Pino Garcia <dpino@igalia.com>
Date:   Fri Oct 12 21:21:25 2018 +0200

    Bug 1453612 - Response.redirect() should have empty string statusText. r=baku

 dom/fetch/Response.cpp                                                         |  1 +
 dom/tests/mochitest/fetch/test_response.js                                     |  1 +
 testing/web-platform/meta/fetch/api/response/response-static-redirect.html.ini | 19 -------------------
 3 files changed, 2 insertions(+), 19 deletions(-)

I don't know what I'm doing wrong :/ I prefer not to push if I'm not sure the tests will pass.
Not doing anything wrong, just treeherder's UI. Let's get this landed.
Keywords: checkin-needed

Comment 10

6 months ago
Pushed by ebalazs@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/eed147a8bd41
Response.redirect() should have empty string statusText. r=baku
Keywords: checkin-needed

Comment 11

6 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/eed147a8bd41
Status: ASSIGNED → RESOLVED
Last Resolved: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
Component: DOM → DOM: Core & HTML
Product: Core → Core
You need to log in before you can comment on or make changes to this bug.