1453637 - Update Debugger Frontend v36

Status: RESOLVED FIXED

(DevTools :: Debugger, enhancement, P3)

Description

[Jason Laster [:jlast]]

https://github.com/devtools-html/debugger.html/compare/release-35...release-36

Comment 1

[Jason Laster [:jlast]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a1bd10177903fcb8eb15d5d13328aa523e82ebc5

Comment 2

[Jason Laster [:jlast]]

Attachment: rel-36.patch

Comment 3

[Jason Laster [:jlast]]

not sure about adding the ember test, curious what others think.

Comment 4

[Jason Laster [:jlast]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a89affefc60b58993d50f64b6e6f0827b7c40097

Comment 5

[Jason Laster [:jlast]]

Attachment: rel-36-2.patch

Comment 6

[Julian Descottes [:jdescottes]]

Comment on attachment 8967559 [details] [diff] [review]
rel-36-2.patch

Review of attachment 8967559 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM. I have a few comments, but we can address them with a future release.

talos: https://treeherder.mozilla.org/perf.html#/compare?originalProject=try&originalRevision=d5214296d58f8d992252ac7f09f83a48cb879128&newProject=try&newRevision=faeead73ae5228a0b0e39aa9a55366fa9ae75331&framework=1

::: devtools/client/debugger/new/test/mochitest/browser.ini
@@ +60,5 @@
> +  examples/ember/quickstart/dist/assets/quickstart.js
> +  examples/ember/quickstart/dist/assets/quickstart.map
> +  examples/ember/quickstart/dist/assets/vendor.css
> +  examples/ember/quickstart/dist/assets/vendor.js
> +  examples/ember/quickstart/dist/assets/vendor.map

Do we need anything on top of those 7 files to run the test? 

I'm not sure if we should keep the all the source to generate the test assets in m-c if that's the case? 
As opposed to being in a separate repo, referenced from the README. 

We can sort that out between this release and the next, I'm curious to know what other peers would suggest here.

::: devtools/client/debugger/new/test/mochitest/browser_dbg-ember-quickstart.js
@@ +1,1 @@
> +

This file might be looked at by people outside of devtools.
Can we add license + comment ? Follow up in next release is fine.

(other debugger mochitests are also missing license headers and a description)

Comment 7

[Jason Laster [:jlast]]

Thanks, I think you're right that we can likely clean up the Ember test quite a bit. 

github.com/devtools-html/debugger.html/issues/5957

Yep, we're working on adding a linter for the licenses. 

github.com/devtools-html/debugger.html/issues/5958

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/256d572bff47
Update Debugger Frontend v36. r=jdescottes

Comment 9

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/256d572bff47