1453724 - sentry should include node versions

Status: RESOLVED FIXED

(Taskcluster :: Services, enhancement)

Description

[Dustin J. Mitchell [:dustin] (he/him)]

process.versions has a bunch of useful versions.  Those should get included in the error report.  It looks like that could be added to `modules` via dataCallback.

https://github.com/getsentry/raven-node/issues/449 too

Comment 1

[Dustin J. Mitchell [:dustin] (he/him)]

Newer versions of raven do.  We're on a very ancient version.

Comment 2

[Dustin J. Mitchell [:dustin] (he/him)]

tc-lib-monitor was already updated to a newer version, but it is not widely disseminated.  I've also landed bug 1452000 in tc-lib-monitor, so I'll upgrade to get both, in some less-than-critical services like hooks.

https://github.com/taskcluster/taskcluster-hooks/pull/92

Comment 3

[[github robot]]

Commit pushed to master at https://github.com/taskcluster/taskcluster-hooks

https://github.com/taskcluster/taskcluster-hooks/commit/979901f7d18085a2c4a85e70aaa763de6ecbb03b
Bug 1453724 - upgrade lib-monitor to get a new raven, among other things

Comment 4

[Dustin J. Mitchell [:dustin] (he/him)]

https://public.etherpad-mozilla.org/p/dustin-1452000-updates

Comment 5

[[github robot]]

Commit pushed to master at https://github.com/taskcluster/taskcluster-index

https://github.com/taskcluster/taskcluster-index/commit/0f20e0b4f94b231b8b09a6b26acf03243f69b4f6
Bug 1452000, 1453724, 1453725 - upgrade tc-lib-monitor for greater good

Comment 6

[[github robot]]

Commit pushed to master at https://github.com/taskcluster/taskcluster-login

https://github.com/taskcluster/taskcluster-login/commit/dbd73bc5330a3f0ae138cf383f43b1c76337c336
Bug 1452000, 1453724, 1453725 - upgrade tc-lib-monitor for greater good

Comment 7

[[github robot]]

Commit pushed to master at https://github.com/taskcluster/taskcluster-queue

https://github.com/taskcluster/taskcluster-queue/commit/79ea2eb733a3fd2ad320c913781dbdd007600dfb
Bug 1452000, 1453724, 1453725 - upgrade tc-lib-monitor for greater good

Comment 8

[Dustin J. Mitchell [:dustin] (he/him)]

That's a rather random assortment of the pushes I made..

Anyway, taskcluster-stats-collector needs some additional TLC here, as it was running a *very* old version of tc-lib-monitor and upgrading causes the tests to fail.  Other than that, this is complete.

Comment 9

[Dustin J. Mitchell [:dustin] (he/him)]

We're going to leave tc-stats-collector as-is.  The major issue seems to be that the updated version of tc-lib-monitor prefixes the project name onto the metric name, so tasks.<workerType>.running becomes tc-stats-collector.tasks.<workerType>.running.  I don't really know if that's a problem.  The service is not part of a redeployable cluster, and may not even be useful for Firefox anymore, so for now I'll just leave it at the ancient version of the library.