1453782 - Record the time it takes to paint the early blank window

Status: RESOLVED FIXED

(Firefox :: General, enhancement)

Description

[Florian Quèze [:florian]]

I would have preferred to re-use the FIRST PAINT existing value for this, but reviewers in bug 1450293 disagree.

Comment 1

[Florian Quèze [:florian]]

Attachment: Patch

Comment 2

[Florian Quèze [:florian]]

Comment on attachment 8967517 [details] [diff] [review]
Patch

Requesting data review:

1. Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

The schema is the same as other timestamps recorded with TelemetryTimestamps.

2. Is there a control mechanism that allows the user to turn the data collection on and off?

Same as the other timestamps recorded through TelemetryTimestamps.

3. If the request is for permanent data collection, is there someone who will monitor the data over time?

I will monitor it for as long as I work on startup performance. We may also want to include it in the dashboard at http://astithas.com/perm/photon-perf/ that managers pay attention to.


4. Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 1 - technical data.

5. Is the data collection request for default-on or default-off?

Default-on.

6. Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?

No.

7. Is the data collection covered by the existing Firefox privacy notice?

Yes.

8. Does there need to be a check-in in the future to determine whether to renew the data? (Yes/No)

Not really. But it would make sense to review all the startup timestamps we are collecting at once, to check what's actually useful and what's obsolete.

Comment 3

[Chris H-C :chutten]

Comment on attachment 8967517 [details] [diff] [review]
Patch

First, with my Firefox Telemetry Team hat on, I will acknowledge that adding things to TelemetryTimestamps (and, thus, simpleMeasurements) isn't ideal. However, the migration of TelemetryTimestamps will likely take no longer for the N+1th use and if it does, then I shall owe :janerik a tasty beverage.

r+ on code use, near as I can tell.

Comment 4

[Florian Quèze [:florian]]

Here is what I'm hoping to get out of this data:
- in the short term, verify that the value drops significantly right after landing bug 1450293 on nightly.
- longer term, on release, verify that the gap between the createTopLevelWindow value and the blankWindowShown value doesn't increase.

We need this information because we care about startup performance, a lot.

I initially considered adapting the first paint measurements, but reviewers in bug 1450293 didn't like it.

Comment 5

[Chris H-C :chutten]

(( the data form's not 100% correct, but the intent and the content is there so I shall proceed ))

DATA COLLECTION REVIEW RESPONSE:

  Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

simpleMeasurements aren't terribly well documented beyond what the code affords, but there is some over here: https://firefox-source-docs.mozilla.org/toolkit/components/telemetry/telemetry/data/main-ping.html#simplemeasurements

As for terminal datasets, this work doesn't cover it entering any dataset other than the raw ping data lake.

  Is there a control mechanism that allows the user to turn the data collection on and off?

Yes, the usual Telemetry checkbox in Preferences.

  If the request is for permanent data collection, is there someone who will monitor the data over time?**

Yes, :florian has committed to it.

  Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under? 

Category 1

  Is the data collection request for default-on or default-off?

Default-on

  Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?

No, just a timestamp.

  Is the data collection covered by the existing Firefox privacy notice?

Yes.

  Does there need to be a check-in in the future to determine whether to renew the data?

No. Though when we get around to turning this into a scalar, it might be worth having it expire so that we do re-evaluate its usefulness after a few versions.

---

result: datareview+

Comment 6

[Panos Astithas (he/him) [:past] (please ni?)]

> I will monitor it for as long as I work on startup performance. We may also
> want to include it in the dashboard at http://astithas.com/perm/photon-perf/
> that managers pay attention to.

This dashboard has been superseded by https://health.graphics/quantum/64 and friends. But yes, we want to add it there too.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/454512091bc2
Record the time it takes to paint the early blank window, r=mconley, data-r=chutten.

Comment 8

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/454512091bc2