Closed Bug 1453803 Opened 3 years ago Closed 3 years ago

no border line of WebExtension's arrow panel

Categories

(WebExtensions :: Frontend, defect)

Product:
WebExtensions
Component:
Frontend
Version:
61 Branch
Platform:
x86_64
Windows 10
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox-esr52 unaffected, firefox59 unaffected, firefox60 unaffected, firefox61 verified)

Status:
VERIFIED FIXED
Milestone:
mozilla61
Tracking Flags:
Tracking Status
firefox-esr52 --- unaffected
firefox59 --- unaffected
firefox60 --- unaffected
firefox61 --- verified

People

(Reporter: alice0775, Assigned: jaws)

References

Details

(Keywords: regression)

Attachments

(3 files)

screenshot
16.97 KB, image/png
Details
Bug 1453803 - Increase the opacity of the default border color for WebExtension popups.
59 bytes, text/x-review-board-request
ntim
: review+
Details
Win10.zip
8.30 KB, application/x-zip-compressed
Details
Attached image screenshot — 
Subject Says It All

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=30228244beafcc1380105dc02e75c0edf17249f9&tochange=88657b4a0dd803dff57d82ee164fb549286d31b5

Regressed by: 88657b4a0dd8	Jared Wein — Bug 1449933 - Webextension popups that don't define a background-color can be hard to read. r=mixedpuppy
Flags: needinfo?(jaws)
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Flags: needinfo?(jaws)
Summary: no border line of WebExtention's arrow panel → no border line of WebExtension's arrow panel
Attachment #8967573 - Flags: review?(ntim.bugs) → review+
Comment on attachment 8967573 [details]
Bug 1453803 - Increase the opacity of the default border color for WebExtension popups.

https://reviewboard.mozilla.org/r/236252/#review242148
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/3d4f1ba7880c
Increase the opacity of the default border color for WebExtension popups. r=ntim
https://hg.mozilla.org/mozilla-central/rev/3d4f1ba7880c
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox61: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Attached file Win10.zip — 
I tested on Nightly (20180412232808) and Nightly (20180426220144) under Win 10 64-bit.

On Nightly (20180412232808) there is no border visible for the pop-up panel and on Nightly (20180426220144) there is a slightly grey border.

This is the expected outcome?
Flags: needinfo?(ntim.bugs)
Flags: needinfo?(jaws)
Seems expected to me that the border color is more visible now, I'll let :jaws confirm.
Flags: needinfo?(ntim.bugs)
Yes, that is expected. Thanks!
Status: RESOLVED → VERIFIED
Flags: needinfo?(jaws)
Product: Toolkit → WebExtensions
You need to log in before you can comment on or make changes to this bug.