Closed Bug 1453862 Opened 3 years ago Closed 3 years ago

Log to web console when autoplay blocked

Categories

(Core :: Audio/Video: Playback, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: cpearce, Assigned: alwu)

References

Details

Attachments

(1 file)

We should really log to the web console when we block autoplay, in order to help web developers debug their sites.
Assignee: cpearce → nobody
Assignee: nobody → alwu
Log to the web console when we block autoplay, in order to help web developers debug their sites.
Comment on attachment 9004419 [details]
Bug 1453862 - Log to web console when autoplay blocked.

Andrea Marchesini [:baku] has approved the revision.
Attachment #9004419 - Flags: review+
In `dom/html/HTMLMediaElement.cpp` on line 4132 there is a typo. It should read `promises`. Perhaps you can fix it with this push?
Flags: needinfo?(alwu)
Sure.
Flags: needinfo?(alwu)
Because I'm not sure whether Phabricator would send notification when I mention someone's name, add NI just in case.
Flags: needinfo?(francesco.lodolo)
Yep, I receive notifications via phabricator. I think it's up to you to decide if you want to have someone looking at the copy, maybe it's not needed since it's a console error. In case, I put an alternative in the comment.
Flags: needinfo?(francesco.lodolo)
Comment on attachment 9004419 [details]
Bug 1453862 - Log to web console when autoplay blocked.

Francesco Lodolo [:flod] has approved the revision.
Attachment #9004419 - Flags: review+
Pushed by alwu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9993da7e3300
Log to web console when autoplay blocked. r=flod,baku
https://hg.mozilla.org/mozilla-central/rev/9993da7e3300
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.