1453876 - Really block Ask.com Toolbar instantiations of accessibility

Status: RESOLVED FIXED

(Core :: Disability Access APIs, enhancement)

Description

[James Teh [:Jamie]]

Bug 1421018 intended to block the Ask.Com Toolbar (tbnotifier.exe). This is basically malware and is responsible for a huge number of unnecessary accessibility instantiations. However, there seems to have been some confusion and we ended up blocking tbnnotifier.exe instead. Let's really block tbnotifier.exe. :)

For reference, a Google search does find some matches for tbnnotifier.exe related to the Ask.com Toolbar, but I'm fairly certain these are typos themselves. This page:
https://answers.microsoft.com/en-us/windows/forum/windows_7-performance/this-application-has-requested-the-runtime-to/df9b7dfe-b21d-4bdc-bb80-ec8170d9ad8c
refers to this file:
Program..s(x86)AskPartnerNetwork\Toolbar\Updater\TBNnotifier.exe
Given the number of missing characters and other weirdness in this string, I'd say it is definitely not an accurate copy/paste job. :)

Comment 1

[James Teh [:Jamie]]

Attachment: Bug 1453876: Fix accessibility blocking of the Ask.com Toolbar.

Bug 1421018 intended to block the Ask.Com Toolbar (tbnotifier.exe).
This is basically malware and is responsible for a huge number of unnecessary accessibility instantiations.
However, there seems to have been some confusion and we ended up blocking tbnnotifier.exe instead.
This changes that block to tbnotifier.exe.

Review commit: https://reviewboard.mozilla.org/r/236364/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/236364/

Comment 2

[Eitan Isaacson [:eeejay]]

Comment on attachment 8967640 [details]
Bug 1453876: Fix accessibility blocking of the Ask.com Toolbar.

https://reviewboard.mozilla.org/r/236364/#review242284

Inspiring patch!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4a34418e88dd
Fix accessibility blocking of the Ask.com Toolbar. r=eeejay

Comment 4

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/4a34418e88dd

Comment 5

[Jim Mathies [:jimm]]

Sorry, I reviewed that but didn't catch the error.