Closed Bug 1453925 Opened 7 years ago Closed 7 years ago

BroadcastChannel doesn't need to use a runnable to dispatch messages

Categories

(Core :: DOM: Core & HTML, enhancement)

Product:
Core
Component:
DOM: Core & HTML
Version:
58 Branch
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla61
Tracking Flags:
Tracking Status
firefox61 --- fixed

People

(Reporter: baku, Assigned: baku)

Details

Attachments

(1 file)

bc.patch
2.84 KB, patch
asuth
: review+
Details | Diff | Splinter Review
Attached patch bc.patch — — Splinter Review
This patch is a subset of another one for bug 1450644. And it has been already reviewed by asuth.
Comment on attachment 8967688 [details] [diff] [review] bc.patch Andrew, quick review here?
Attachment #8967688 - Flags: review?(bugmail)
Comment on attachment 8967688 [details] [diff] [review] bc.patch Review of attachment 8967688 [details] [diff] [review]: ----------------------------------------------------------------- Right, review of the superset patch at https://bugzilla.mozilla.org/show_bug.cgi?id=1450644#c7
Attachment #8967688 - Flags: review?(bugmail) → review+
Pushed by amarchesini@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/efa6394f2a4a BroadcastChannel doesn't need to use a runnable to dispatch messages, r=asuth
https://hg.mozilla.org/mozilla-central/rev/efa6394f2a4a
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox61: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Backout by csabou@mozilla.com: https://hg.mozilla.org/mozilla-central/rev/a79d460bf2a3 Backed out changeset efa6394f2a4a for mochitest failures on test_broadcastchannel_worker_alive.html. a=backout
Backed out changeset for mochitest perma failures on test_broadcastchannel_worker_alive.html Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=efa6394f2a4a47735c03f5c9b1953665c17b555e&filter-searchStr=mochitest&selectedJob=173634780 Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=173634780&repo=mozilla-inbound&lineNumber=7541 [task 2018-04-13T23:50:01.813Z] 23:50:01 INFO - TEST-START | dom/broadcastchannel/tests/test_broadcastchannel_worker_alive.html [task 2018-04-13T23:55:28.797Z] 23:55:28 INFO - TEST-INFO | started process screentopng [task 2018-04-13T23:55:29.100Z] 23:55:29 INFO - TEST-INFO | screentopng: exit 0 [task 2018-04-13T23:55:29.102Z] 23:55:29 INFO - Buffered messages logged at 23:50:01 [task 2018-04-13T23:55:29.102Z] 23:55:29 INFO - MSG: READY [task 2018-04-13T23:55:29.103Z] 23:55:29 INFO - TEST-PASS | dom/broadcastchannel/tests/test_broadcastchannel_worker_alive.html | Worker is ready! [task 2018-04-13T23:55:29.103Z] 23:55:29 INFO - Buffered messages finished [task 2018-04-13T23:55:29.105Z] 23:55:29 INFO - TEST-UNEXPECTED-FAIL | dom/broadcastchannel/tests/test_broadcastchannel_worker_alive.html | Test timed out. [task 2018-04-13T23:55:29.105Z] 23:55:29 INFO - reportError@SimpleTest/TestRunner.js:121:7 [task 2018-04-13T23:55:29.106Z] 23:55:29 INFO - TestRunner._checkForHangs@SimpleTest/TestRunner.js:142:7 [task 2018-04-13T23:55:29.106Z] 23:55:29 INFO - setTimeout handler*TestRunner._checkForHangs@SimpleTest/TestRunner.js:163:5 [task 2018-04-13T23:55:29.107Z] 23:55:29 INFO - setTimeout handler*TestRunner._checkForHangs@SimpleTest/TestRunner.js:163:5 [task 2018-04-13T23:55:29.108Z] 23:55:29 INFO - setTimeout handler*TestRunner._checkForHangs@SimpleTest/TestRunner.js:163:5 [task 2018-04-13T23:55:29.108Z] 23:55:29 INFO - setTimeout handler*TestRunner._checkForHangs@SimpleTest/TestRunner.js:163:5 [task 2018-04-13T23:55:29.109Z] 23:55:29 INFO - setTimeout handler*TestRunner._checkForHangs@SimpleTest/TestRunner.js:163:5 [task 2018-04-13T23:55:29.109Z] 23:55:29 INFO - setTimeout handler*TestRunner._checkForHangs@SimpleTest/TestRunner.js:163:5 [task 2018-04-13T23:55:29.110Z] 23:55:29 INFO - setTimeout handler*TestRunner._checkForHangs@SimpleTest/TestRunner.js:163:5 [task 2018-04-13T23:55:29.111Z] 23:55:29 INFO - setTimeout handler*TestRunner._checkForHangs@SimpleTest/TestRunner.js:163:5 [task 2018-04-13T23:55:29.111Z] 23:55:29 INFO - setTimeout handler*TestRunner._checkForHangs@SimpleTest/TestRunner.js:163:5 [task 2018-04-13T23:55:29.112Z] 23:55:29 INFO - setTimeout handler*TestRunner._checkForHangs@SimpleTest/TestRunner.js:163:5 [task 2018-04-13T23:55:29.112Z] 23:55:29 INFO - setTimeout handler*TestRunner._checkForHangs@SimpleTest/TestRunner.js:163:5 [task 2018-04-13T23:55:29.113Z] 23:55:29 INFO - TestRunner.runTests@SimpleTest/TestRunner.js:380:5 [task 2018-04-13T23:55:29.114Z] 23:55:29 INFO - RunSet.runtests@SimpleTest/setup.js:194:3 [task 2018-04-13T23:55:29.115Z] 23:55:29 INFO - RunSet.runall@SimpleTest/setup.js:173:5 [task 2018-04-13T23:55:29.115Z] 23:55:29 INFO - hookupTests@SimpleTest/setup.js:266:5 [task 2018-04-13T23:55:29.116Z] 23:55:29 INFO - parseTestManifest@http://mochi.test:8888/manifestLibrary.js:36:5 [task 2018-04-13T23:55:29.117Z] 23:55:29 INFO - getTestManifest/req.onload@http://mochi.test:8888/manifestLibrary.js:49:11 [task 2018-04-13T23:55:29.118Z] 23:55:29 INFO - EventHandlerNonNull*getTestManifest@http://mochi.test:8888/manifestLibrary.js:45:3 [task 2018-04-13T23:55:29.118Z] 23:55:29 INFO - hookup@SimpleTest/setup.js:246:5 [task 2018-04-13T23:55:29.118Z] 23:55:29 INFO - EventHandlerNonNull*@http://mochi.test:8888/tests?autorun=1&closeWhenDone=1&consoleLevel=INFO&manifestFile=tests.json&dumpOutputDirectory=%2Ftmp&cleanupCrashes=true:11:1 [task 2018-04-13T23:55:29.800Z] 23:55:29 INFO - GECKO(4570) | MEMORY STAT | vsize 1624MB | residentFast 163MB | heapAllocated 20MB Backout link: https://hg.mozilla.org/mozilla-central/rev/a79d460bf2a33fd79c6646236f9c4df78e66e7b7
Status: RESOLVED → REOPENED
status-firefox61: fixed → ---
Flags: needinfo?(amarchesini)
Resolution: FIXED → ---
Target Milestone: mozilla61 → ---
Is it intermittent also on m-i?
Flags: needinfo?(amarchesini) → needinfo?(nerli)
Andrea, yes this was intermittent on inbound but it failed on different platform pretty often. https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&filter-searchStr=opt-mochitest-e10s&tochange=f291b07fa1f869fd3f9af9f5fe940d47b842edcf&fromchange=efa6394f2a4a47735c03f5c9b1953665c17b555e&selectedJob=173723756 And you can see from here https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1438746 how that failed across all trees in that time frame, from being pushed on inbound until the backout on central.
Flags: needinfo?(nerli)
Pushed by amarchesini@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/71b23fab4c0b BroadcastChannel doesn't need to use a runnable to dispatch messages, r=asuth
It was a bug in dom/broadcastchannel/tests/test_broadcastchannel_worker_alive.html.
https://hg.mozilla.org/mozilla-central/rev/71b23fab4c0b
Status: REOPENED → RESOLVED
Closed: 7 years ago → 7 years ago
status-firefox61: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: