Closed
Bug 1453932
Opened 6 years ago
Closed 6 years ago
Optimize loads from CallSiteObject (tagged template literals)
Categories
(Core :: JavaScript Engine: JIT, enhancement, P3)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
mozilla61
Tracking | Status | |
---|---|---|
firefox61 | --- | fixed |
People
(Reporter: evilpie, Assigned: evilpie)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 2 obsolete files)
4.74 KB,
patch
|
jandem
:
review+
|
Details | Diff | Splinter Review |
The object with strings that we create for tagged templates is a constant frozen array, so we should be able to optimize the loads from that array. I have a patch seems to work, but needs a few more comments and some of those trackOptimizationAttempt things.
Assignee | ||
Comment 1•6 years ago
|
||
Assignee | ||
Comment 2•6 years ago
|
||
Assignee | ||
Updated•6 years ago
|
Attachment #8967696 -
Attachment is obsolete: true
Assignee | ||
Updated•6 years ago
|
Attachment #8968482 -
Flags: review?(jdemooij)
Comment 3•6 years ago
|
||
Comment on attachment 8968482 [details] [diff] [review] Optimize loads from CallSiteObjects for tagged template literals Review of attachment 8968482 [details] [diff] [review]: ----------------------------------------------------------------- Sweet. ::: js/src/jit-test/tests/ion/template-tag-callsiteobject.js @@ +1,2 @@ > +function tagA(strings) { > + assertEq(strings.length, 2); Nit: the indentation in this test looks a bit off. ::: js/src/jit/IonBuilder.cpp @@ +8251,5 @@ > +IonBuilder::getElemTryCallSiteObject(bool* emitted, MDefinition* obj, MDefinition* index) > +{ > + MOZ_ASSERT(*emitted == false); > + > + if (!obj->isConstant() || obj->type() != MIRType::Object) { Nit: no {} here and ~4 times below.
Attachment #8968482 -
Flags: review?(jdemooij) → review+
Updated•6 years ago
|
Priority: -- → P3
Assignee | ||
Comment 4•6 years ago
|
||
Assignee | ||
Updated•6 years ago
|
Attachment #8968482 -
Attachment is obsolete: true
Assignee | ||
Updated•6 years ago
|
Attachment #8969205 -
Flags: review?(jdemooij)
Updated•6 years ago
|
Attachment #8969205 -
Flags: review?(jdemooij) → review+
Pushed by evilpies@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/0a19791ab773 Optimize loads from CallSiteObjects for tagged template literals. r=jandem
Assignee | ||
Comment 6•6 years ago
|
||
On AWFY this didn't help on the expected test templatestringtag-es6. Instead we seem to have a reversed a regression on map-set-es6. GC timing maybe?
Comment 7•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/0a19791ab773
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in
before you can comment on or make changes to this bug.
Description
•