Closed Bug 1454023 Opened 6 years ago Closed 4 years ago

Port |Bug 1431050 - "remove NS_ASSERT / debug.js"| to SeaMonkey

Categories

(SeaMonkey :: General, task, P3)

Product:
SeaMonkey
Component:
General
Type:
task

Tracking

(seamonkey2.58 wontfix, seamonkey2.53 fixed, seamonkey2.57esr fixed)

Status:
VERIFIED FIXED
Milestone:
seamonkey 2.71
Tracking Flags:
Tracking Status
seamonkey2.58 --- wontfix
seamonkey2.53 --- fixed
seamonkey2.57esr --- fixed

People

(Reporter: frg, Assigned: iannbugzilla)

References

(Blocks 1 open bug)

Details

(Whiteboard: SM2.53.2)

Attachments

(3 files, 3 obsolete files)

Remove NS_ASSERT for SM trunk v1.1
20.77 KB, patch
frg
: review+
Details | Diff | Splinter Review
Remove NS_ASSERT for SM 2.57 v1.1
20.67 KB, patch
frg
: review+
frg
: approval-comm-esr60+
Details | Diff | Splinter Review
Remove NS_ASSERT for SM 2.53.x v1.1
20.80 KB, patch
frg
: review+
frg
: approval-comm-release+
Details | Diff | Splinter Review 
debug.js has been removed and NS_ASSERT needs  to changed. 

+++ This bug was initially created as a clone of Bug #1431050 +++

Filing in Places because NS_ASSERT is used mostly in Places code (21 callers).

https://searchfox.org/mozilla-central/search?q=NS_ASSERT&case=false&regexp=false&path=.js
Hello, I'm an absolute beginner and would like to work on this.
Replace the NS_ASSERT calls in this search:

https://searchfox.org/comm-central/search?q=NS_ASSERT&case=false&regexp=false&path=^suite%2F**.js%24

For details see Bug #1431050
Assignee: nobody → devikasugathan007
bblack, we usually only assign when there is a patch attached unless it is a known contributor.

Devika, SeaMonkey is currently broken in comm-central. I would pick older bugs with affected version <= 2.57 or you won't be able to test this.
Assignee: devikasugathan007 → nobody
Assignee: nobody → iann_bugzilla
Status: NEW → ASSIGNED
Type: enhancement → task
OS: Unspecified → All
Hardware: Unspecified → All
Summary: Port Bug 1431050 "remove NS_ASSERT / debug.js" to SeaMonkey → Port |Bug 1431050 - "remove NS_ASSERT / debug.js"| to SeaMonkey

The sessionstore change was sort of made for m-c in Bug 894595 - part 1.6 - Move session history collection into a module

Attached patch Remove NS_ASSERT for SM trunk (obsolete) — — Splinter Review
Attachment #9122667 - Flags: review?(frgrahl)
Attached patch Remove NS_ASSERT for SM 2.57 (obsolete) — — Splinter Review
Attachment #9122668 - Flags: review?(frgrahl)
Attachment #9122668 - Flags: approval-comm-esr60?
Attached patch Remove NS_ASSERT for SM 2.53.x (obsolete) — — Splinter Review
Attachment #9122669 - Flags: review?(frgrahl)
Attachment #9122669 - Flags: approval-comm-release?
Blocks: 1611647
No longer blocks: 1611647

Fixed title/type confusion

Attachment #9122667 - Attachment is obsolete: true
Attachment #9122667 - Flags: review?(frgrahl)
Attachment #9124081 - Flags: review?(frgrahl)

Fixed title/type confusion

Attachment #9122668 - Attachment is obsolete: true
Attachment #9122668 - Flags: review?(frgrahl)
Attachment #9122668 - Flags: approval-comm-esr60?
Attachment #9124082 - Flags: review?(frgrahl)
Attachment #9124082 - Flags: approval-comm-esr60?

Fixed title/type confusion

Attachment #9122669 - Attachment is obsolete: true
Attachment #9122669 - Flags: review?(frgrahl)
Attachment #9122669 - Flags: approval-comm-release?
Attachment #9124084 - Flags: review?(frgrahl)
Attachment #9124084 - Flags: approval-comm-release?
Comment on attachment 9124081 [details] [diff] [review]
Remove NS_ASSERT for SM trunk v1.1

LGTM
Attachment #9124081 - Flags: review?(frgrahl) → review+
Comment on attachment 9124082 [details] [diff] [review]
Remove NS_ASSERT for SM 2.57 v1.1

LGTM
Attachment #9124082 - Flags: review?(frgrahl)
Attachment #9124082 - Flags: review+
Attachment #9124082 - Flags: approval-comm-esr60?
Attachment #9124082 - Flags: approval-comm-esr60+
Comment on attachment 9124084 [details] [diff] [review]
Remove NS_ASSERT for SM 2.53.x v1.1

LGTM

Unrelated: Wonder if we shouldn't kill the non async places api in 2.53.
Attachment #9124084 - Flags: review?(frgrahl)
Attachment #9124084 - Flags: review+
Attachment #9124084 - Flags: approval-comm-release?
Attachment #9124084 - Flags: approval-comm-release+

Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/000158b2aa70
Port |Bug 1431050 - "remove NS_ASSERT / debug.js"| to SeaMonkey trunk. r=frg

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey 2.71

"Bug 1613033 "New bookmark folder" dialog crippled, input fields missing"
is NOT longer reproducible with installation of unofficial (by wg9s) De SeaMonkey 2.53.2 beta 1 pre Mozilla/5.0 (NT 6.1; Win64; x64; rv:60.0) Gecko/20100101 Firefox/60.0 Build 20200211130005 (Default Classic Theme, newly created User Profile) on German WIN7 64bit

So VERIFIED for now

Status: RESOLVED → VERIFIED
status-seamonkey2.53: --- → fixed
status-seamonkey2.57esr: --- → fixed
status-seamonkey2.58: affected → wontfix
Whiteboard: SM2.53.2
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: