1454054 - Remove QI in nsRange::CollectClientRectsAndText()

Status: NEW

(Core :: DOM: Core & HTML, enhancement, P3)

Description

[Andrew McCreight [:mccr8]]

I removed one of these QIs, but the other could also be removed.

(In reply to Boris Zbarsky [:bz] (no decent commit message means r-) from comment #5)
> ::: dom/base/nsRange.cpp:3077
> (Diff revision 1)
> >    nsresult rv = iter.Init(aRange);
> >    if (NS_FAILED(rv)) return;
> >  
> >    if (iter.IsDone()) {
> >      // the range is collapsed, only continue if the cursor is in a text node
> >      nsCOMPtr<nsIContent> content = do_QueryInterface(aStartContainer);
> 
> You could avoid this QI like so:
> 
>     if (aStartContainer->IsText()) {
>       nsTextFrame* textFrame =
> GetTextFrameForContent(aStartContainer->AsText(), aFlushLayout);
>       
> etc.
> 
> ::: dom/base/nsRange.cpp:3104
> (Diff revision 1)
> >    }
> >  
> >    do {
> >      nsCOMPtr<nsINode> node = iter.GetCurrentNode();
> >      iter.Next();
> >      nsCOMPtr<nsIContent> content = do_QueryInterface(node);
> 
> Should be able to avoi this QI too, but that's more work.  Maybe file a
> followup?