Open Bug 1454132 Opened 6 years ago Updated 2 years ago

Remove NO_CHROMIUM_LOGGING

Categories

(Core :: IPC, enhancement, P3)

Product:
Core
Component:
IPC
Version:
60 Branch
Type:
enhancement

Tracking

()

People

(Reporter: jld, Unassigned)

References

Details

ipc/chromium/src/base/logging.h supports defining NO_CHROMIUM_LOGGING to make the logging macros no-ops.  This doesn't appear to used, and it's a bad idea to leave it there as a dormant footgun: there are assertions that macro-expand to CHROMIUM_LOG(FATAL) which would become non-fatal.  It should be removed.
Priority: -- → P3
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.