1454161 - spidermonkey fails for wasm/gc/anyref.js and wasm/gc/disabled.js when Gecko 61 merges to Beta on 2018-04-26

Status: VERIFIED FIXED

(Core :: JavaScript Engine: JIT, defect, P1)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Fallout from bug 1445277.

central-as-beta simulation: https://treeherder.mozilla.org/#/jobs?repo=try&revision=4acef5b88f005572ecc9e5c4b467e8929fe40355&group_state=expanded&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable&selectedJob=173683310

If you want to test it on Try, import those two patches listed for that Try push.

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=173683310&repo=try

TEST-UNEXPECTED-FAIL | js/src/jit-test/tests/wasm/gc/anyref.js | Error: Invalid long option: --wasm-gc (code 1, args "--wasm-gc") [0.0 s]
TEST-UNEXPECTED-FAIL | js/src/jit-test/tests/wasm/gc/disabled.js | Error: Invalid long option: --wasm-gc (code 1, args "--wasm-gc") [0.0 s]

Comment 1

[Lars T Hansen [:lth]]

Hm yes, we probably want to recognize this option even if the feature is not enabled, to avoid this problem.  We can have a good help text for it in that case, so that users will know it does nothing.

Will discuss with Benjamin on Monday.

Comment 2

[Benjamin Bouvier [:bbouvier] (inactive)]

Attachment: fix.patch

Yes, agreed. I happen to have made this fix in the train this morning.

Comment 3

[Lars T Hansen [:lth]]

Comment on attachment 8968187 [details] [diff] [review]
fix.patch

Review of attachment 8968187 [details] [diff] [review]:
-----------------------------------------------------------------

Yeah, ship it.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/44662c81a04d
Make --wasm-gc a no-op in non-Nightly builds; r=lth

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/44662c81a04d

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

This has been verified as fixed with the latest central-as-beta simulation: https://treeherder.mozilla.org/#/jobs?repo=try&revision=f003aa5aa30716b2ab7d1f1ea7a58866130141bb&group_state=expanded&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable