Closed
Bug 1454161
Opened 6 years ago
Closed 6 years ago
spidermonkey fails for wasm/gc/anyref.js and wasm/gc/disabled.js when Gecko 61 merges to Beta on 2018-04-26
Categories
(Core :: JavaScript Engine: JIT, defect, P1)
Core
JavaScript Engine: JIT
Tracking
()
VERIFIED
FIXED
mozilla61
Tracking | Status | |
---|---|---|
firefox-esr52 | --- | unaffected |
firefox59 | --- | unaffected |
firefox60 | --- | unaffected |
firefox61 | + | verified |
People
(Reporter: aryx, Assigned: bbouvier)
References
Details
Attachments
(1 file)
1.66 KB,
patch
|
lth
:
review+
|
Details | Diff | Splinter Review |
Fallout from bug 1445277. central-as-beta simulation: https://treeherder.mozilla.org/#/jobs?repo=try&revision=4acef5b88f005572ecc9e5c4b467e8929fe40355&group_state=expanded&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable&selectedJob=173683310 If you want to test it on Try, import those two patches listed for that Try push. Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=173683310&repo=try TEST-UNEXPECTED-FAIL | js/src/jit-test/tests/wasm/gc/anyref.js | Error: Invalid long option: --wasm-gc (code 1, args "--wasm-gc") [0.0 s] TEST-UNEXPECTED-FAIL | js/src/jit-test/tests/wasm/gc/disabled.js | Error: Invalid long option: --wasm-gc (code 1, args "--wasm-gc") [0.0 s]
Flags: needinfo?(lhansen)
Comment 1•6 years ago
|
||
Hm yes, we probably want to recognize this option even if the feature is not enabled, to avoid this problem. We can have a good help text for it in that case, so that users will know it does nothing. Will discuss with Benjamin on Monday.
Assignee: nobody → lhansen
Flags: needinfo?(lhansen)
Updated•6 years ago
|
Assignee | ||
Comment 2•6 years ago
|
||
Yes, agreed. I happen to have made this fix in the train this morning.
Comment 3•6 years ago
|
||
Comment on attachment 8968187 [details] [diff] [review] fix.patch Review of attachment 8968187 [details] [diff] [review]: ----------------------------------------------------------------- Yeah, ship it.
Attachment #8968187 -
Flags: review?(lhansen) → review+
Updated•6 years ago
|
Priority: -- → P1
Pushed by bbouvier@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/44662c81a04d Make --wasm-gc a no-op in non-Nightly builds; r=lth
Comment 5•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/44662c81a04d
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Reporter | ||
Comment 6•6 years ago
|
||
This has been verified as fixed with the latest central-as-beta simulation: https://treeherder.mozilla.org/#/jobs?repo=try&revision=f003aa5aa30716b2ab7d1f1ea7a58866130141bb&group_state=expanded&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•