1454322 - The inverted value is set to dom.ipc.plugins.flash.disable-protected-mode via "Enable Adobe Flash protected mode"

Status: RESOLVED DUPLICATE of bug 1451452

(Toolkit :: Add-ons Manager, defect)

Description

[Kentaro Hayashi [:kenhys]]

## Problem

There are mismatch between Shockwave Flash configuration via user interface and the value of preference about dom.ipc.plugins.flash.disable-protected-mode.
I mean mismatch - Flash configuration and preference value is inverted, so UI is useless to configure as you expected.

## Expected

There is no mismatch between Flash configuration via user interface and the value of preference. It is set correctly as you expected.

## Actual

The inverted value is set to preference. This behavior is very confused for users because users can't control preference as you see.

Case 1.

If you checked "Enable Adobe Flash protected mode", the value of dom.ipc.plugins.flash.disable-protected-mode is changed to true.
It must be false because we want to enable protected mode!

Case 2.

If you unchecked "Enable Adobe Flash protected mode", the value of dom.ipc.plugins.flash.disable-protected-mode is changed to false.
It must be true because we want to disable protected mode!


This bug is introduced by Bug 1414406 Switch plugins to use inline browser options.

In contrast to esr52, implementation is changed from
  https://dxr.mozilla.org/mozilla-esr52/source/toolkit/mozapps/extensions/content/pluginPrefs.xul#16
to: https://dxr.mozilla.org/mozilla-central/source/toolkit/mozapps/extensions/content/pluginPrefs.js#11

Here is the snippet in previous implementation:

 <setting type="bool" pref="dom.ipc.plugins.flash.disable-protected-mode"
           inverted="true" title="&plugin.flashProtectedMode.label;"
           id="pluginEnableProtectedMode"
           learnmore="https://support.mozilla.org/kb/flash-protected-mode-settings" />

Important point is the above inverted="true" xul attribute is not ported at all in Bug 1414406 implementation.