Closed
Bug 1454322
Opened 7 years ago
Closed 7 years ago
The inverted value is set to dom.ipc.plugins.flash.disable-protected-mode via "Enable Adobe Flash protected mode"
Categories
(Toolkit :: Add-ons Manager, defect)
Tracking
()
RESOLVED
DUPLICATE
of bug 1451452
People
(Reporter: kenhys, Unassigned)
References
Details
(Keywords: regression)
## Problem
There are mismatch between Shockwave Flash configuration via user interface and the value of preference about dom.ipc.plugins.flash.disable-protected-mode.
I mean mismatch - Flash configuration and preference value is inverted, so UI is useless to configure as you expected.
## Expected
There is no mismatch between Flash configuration via user interface and the value of preference. It is set correctly as you expected.
## Actual
The inverted value is set to preference. This behavior is very confused for users because users can't control preference as you see.
Case 1.
If you checked "Enable Adobe Flash protected mode", the value of dom.ipc.plugins.flash.disable-protected-mode is changed to true.
It must be false because we want to enable protected mode!
Case 2.
If you unchecked "Enable Adobe Flash protected mode", the value of dom.ipc.plugins.flash.disable-protected-mode is changed to false.
It must be true because we want to disable protected mode!
This bug is introduced by Bug 1414406 Switch plugins to use inline browser options.
In contrast to esr52, implementation is changed from
https://dxr.mozilla.org/mozilla-esr52/source/toolkit/mozapps/extensions/content/pluginPrefs.xul#16
to: https://dxr.mozilla.org/mozilla-central/source/toolkit/mozapps/extensions/content/pluginPrefs.js#11
Here is the snippet in previous implementation:
<setting type="bool" pref="dom.ipc.plugins.flash.disable-protected-mode"
inverted="true" title="&plugin.flashProtectedMode.label;"
id="pluginEnableProtectedMode"
learnmore="https://support.mozilla.org/kb/flash-protected-mode-settings" />
Important point is the above inverted="true" xul attribute is not ported at all in Bug 1414406 implementation.
Reporter | ||
Updated•7 years ago
|
status-firefox60:
--- → affected
Version: Trunk → 60 Branch
Reporter | ||
Updated•7 years ago
|
Component: Plug-ins → Add-ons Manager
Product: Core → Toolkit
Updated•7 years ago
|
![]() |
||
Updated•7 years ago
|
Depends on: CVE-2018-5165
Updated•7 years ago
|
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → DUPLICATE
Updated•7 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•