Closed Bug 1454331 Opened 2 years ago Closed 2 years ago

Don't use rgba() for popup_text in the Dark theme

Categories

(Firefox :: Theme, defect, P3)

defect

Tracking

()

RESOLVED FIXED
Firefox 61
Tracking Status
firefox-esr52 --- unaffected
firefox59 --- unaffected
firefox60 --- unaffected
firefox61 --- fixed

People

(Reporter: dao, Assigned: ntim, NeedInfo)

References

Details

(Keywords: regression)

Attachments

(1 file)

Using the alpha channel for text color is asking for trouble with regards to rendering quality (i.e. subpixel AA). It should be avoided where possible.

Tim, can you take this?
Flags: needinfo?(ntim.bugs)
Just out of curiosity, how bad is the difference on Linux ? I can't notice the difference on Mac.
Flags: needinfo?(ntim.bugs)
Assignee: nobody → ntim.bugs
Patrick, will Pathfinder lose subpixel AA when a translucent font is being drawn? Are there any things that we should look out for?
Flags: needinfo?(pwalton)
Comment on attachment 8968339 [details]
Bug 1454331 - Don't use rgba() for popup_text in the Dark theme.

https://reviewboard.mozilla.org/r/237008/#review242840
Attachment #8968339 - Flags: review?(jaws) → review+
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/6d609d7d44de
Don't use rgba() for popup_text in the Dark theme. r=jaws
(In reply to Tim Nguyen :ntim from comment #2)
> Just out of curiosity, how bad is the difference on Linux ? I can't notice
> the difference on Mac.

I haven't actually tested it. We might already be using grayscale AA in popups on Mac for other reasons. Or maybe we can now use subpixel AA on Mac in such situations which would be nice. My primary concern here is Windows, where I think you might be getting different results depending on the level of GPU utilization. It's a bit hard to predict and we have a not so great track record of subpar text rendering in chrome. The bottom line is, if there's no good reason to use transparency, just avoid it.
https://hg.mozilla.org/mozilla-central/rev/6d609d7d44de
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
You need to log in before you can comment on or make changes to this bug.