1454331 - Don't use rgba() for popup_text in the Dark theme

Status: RESOLVED FIXED

(Firefox :: Theme, defect, P3)

Description

[Dão Gottwald [:dao]]

Using the alpha channel for text color is asking for trouble with regards to rendering quality (i.e. subpixel AA). It should be avoided where possible.

Tim, can you take this?

Comment 1

[Tim Nguyen :ntim]

Attachment: Bug 1454331 - Don't use rgba() for popup_text in the Dark theme.

Review commit: https://reviewboard.mozilla.org/r/237008/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/237008/

Comment 2

[Tim Nguyen :ntim]

Just out of curiosity, how bad is the difference on Linux ? I can't notice the difference on Mac.

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Patrick, will Pathfinder lose subpixel AA when a translucent font is being drawn? Are there any things that we should look out for?

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8968339 [details]
Bug 1454331 - Don't use rgba() for popup_text in the Dark theme.

https://reviewboard.mozilla.org/r/237008/#review242840

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6d609d7d44de
Don't use rgba() for popup_text in the Dark theme. r=jaws

Comment 6

[Dão Gottwald [:dao]]

(In reply to Tim Nguyen :ntim from comment #2)
> Just out of curiosity, how bad is the difference on Linux ? I can't notice
> the difference on Mac.

I haven't actually tested it. We might already be using grayscale AA in popups on Mac for other reasons. Or maybe we can now use subpixel AA on Mac in such situations which would be nice. My primary concern here is Windows, where I think you might be getting different results depending on the level of GPU utilization. It's a bit hard to predict and we have a not so great track record of subpar text rendering in chrome. The bottom line is, if there's no good reason to use transparency, just avoid it.

Comment 7

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/6d609d7d44de