1454408 - Clean up preferences calls needing default values in SeaMonkey

Status: RESOLVED FIXED

(SeaMonkey :: Preferences, enhancement)

Description

[Frank-Rainer Grahl (:frg)]

Services.prefs.getIntPref, Services.prefs.getBoolPref and Services.prefs.getStringPref can now take a default entry starting with Geck 54 / SeaMonkey 2.51. We can now replace GetIntPref, GetBoolPref and GetStringPref with the standard calls and remove the old functions.

Comment 1

[Frank-Rainer Grahl (:frg)]

Attachment: 1454408-suiteprefs.patch

suite part

Comment 2

[Frank-Rainer Grahl (:frg)]

Attachment: 1454408-editorprefs.patch

SeaMonkey Composer part.

mail and mailnews do not need similiar patches. Need to test them in 2.53 before I ask for review.

Comment 3

[Frank-Rainer Grahl (:frg)]

Comment on attachment 8968225 [details] [diff] [review]
1454408-suiteprefs.patch

Seems to be ok.

Comment 4

[Frank-Rainer Grahl (:frg)]

Comment on attachment 8968227 [details] [diff] [review]
1454408-editorprefs.patch

Seems to be ok.

Comment 5

[Frank-Rainer Grahl (:frg)]

Additional note. Services.prefs.getStringPref can only used in 58 / 2.55 and up.

Comment 6

[Ian Neal]

Comment on attachment 8968225 [details] [diff] [review]
1454408-suiteprefs.patch

>+++ b/suite/common/utilityOverlay.js

>-  var loadInBackground = GetBoolPref("browser.tabs.loadInBackground", false);
>+  var loadInBackground =
>+    Services.prefs.getBoolPref("browser.tabs.loadInBackground");
We've lost the false argument here...

>-  var loadInBackground = GetBoolPref("browser.tabs.loadInBackground", false);
>+  var loadInBackground = 
>+    Services.prefs.getBoolPref("browser.tabs.loadInBackground");
...and here.

r=me with those fixed.

Comment 7

[Ian Neal]

Comment on attachment 8968227 [details] [diff] [review]
1454408-editorprefs.patch

LGTM r=me

Comment 8

[Frank-Rainer Grahl (:frg)]

> ...and here.
> r=me with those fixed.

This was deliberate. We define it in suite/browser/browser-prefs.js and the calls are inconsistent. The default is not needed. See

https://dxr.mozilla.org/comm-central/search?q=browser.tabs.loadInBackground&redirect=false

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/4d0730901995
Replace getPref calls needing a default value with standard Services calls. Suite part. r=IanN DONTBUILD
https://hg.mozilla.org/comm-central/rev/bd8822971340
Replace getPref calls needing a default value with standard Services calls. SeaMonkey Composer part. r=IanN DONTBUILD

Comment 10

[Frank-Rainer Grahl (:frg)]

Comment on attachment 8968225 [details] [diff] [review]
1454408-suiteprefs.patch

[Approval Request Comment]
Regression caused by (bug #): --
User impact if declined: The fishes told me that they dislike the current code.
Testing completed (on m-c, etc.): c-b c-r (without strings) in 2.53
Risk to taking this patch (and alternatives if risky): just a cleanup
String changes made by this patch: --

Comment 11

[Frank-Rainer Grahl (:frg)]

Attachment: 1454408-editorprefs-253.patch

2.53 version if ever needed

Comment 12

[Frank-Rainer Grahl (:frg)]

Attachment: 1454408-suiteprefs-253.patch

2.53 version if ever needed

Comment 13

[Jorg K (CEST = GMT+2)]

Who do you expect to approve the beta, me or Ian? One patch is suite/ only, the other one is editor/, so I could approve that one, but since this is a SM bug, I can't approve anything :-(

Comment 14

[Frank-Rainer Grahl (:frg)]

Thanks for asking. Composer only and not really urgent (just to make backports easier) so I think IanN should do it. SeaMonkey 2.57 based on 60 goes nowhere in the next few months :(

Comment 15

[Ian Neal]

Comment on attachment 8968225 [details] [diff] [review]
1454408-suiteprefs.patch

a=me

Comment 16

[Ian Neal]

Comment on attachment 8968227 [details] [diff] [review]
1454408-editorprefs.patch

a=me

Comment 17

[Frank-Rainer Grahl (:frg)]

https://hg.mozilla.org/releases/comm-beta/rev/a59b0b5ac649
https://hg.mozilla.org/releases/comm-beta/rev/78712c7817d3

Comment 18

[Frank-Rainer Grahl (:frg)]

Attachment: 1454408-typofix.patch

doh ...

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/22f53205439f
Followup typo fix. r=me

Comment 20

[Frank-Rainer Grahl (:frg)]

https://hg.mozilla.org/releases/comm-esr60/rev/db082b43f03470f006fd002752d4f66f519a8dfa

Comment 22

[Frank-Rainer Grahl (:frg)]

Target 2.53.1
https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/1fc0cc36a78bc4a30146072b9ae7a7138cc24197
Replace getPref calls needing a default value with standard Services calls. Suite part.
https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/c7ef12754d97bd9f6fa57d20a9dd733add33724b
Replace getPref calls needing a default value with standard Services calls. SeaMonkey Composer part.
https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/fc7b4bd2cea8c3e4ce38d387057e0729b7dfeccf
Followup typo fix. r=me a=me

Target 2.53.3
https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/ca7901a632e73207df2fd4416cbdbf1f8a49e317
Replace getPref calls needing a default value with standard Services calls. Follow-up for 2.53.3. r=IanN a=IanN