Closed Bug 1454430 Opened 2 years ago Closed 2 years ago

Crash in static struct mozilla::layers::CompositorBridgeParent::LayerTreeState* mozilla::layers::GetStateForRoot

Categories

(Core :: Graphics: Layers, defect, P1, critical)

Unspecified
Windows 8
defect

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox-esr52 --- unaffected
firefox59 --- unaffected
firefox60 --- unaffected
firefox61 + fixed

People

(Reporter: marcia, Assigned: kats)

References

Details

(Keywords: crash, regression, Whiteboard: [gfx-noted])

Crash Data

Attachments

(1 file)

This bug was filed from the Socorro interface and is
report bp-ed31171e-b59a-4019-8b2c-585ca0180404.
=============================================================

Seen while looking at nightly crash data - small volume regression which looks to have started using Build 20180316100132: https://bit.ly/2viYCSd.

Possible regression range based on Build ID: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=68dfe5ee5b80ee99b7e389d739a30089f6f1e55d&tochange=c488b8d0e074efb490ebca32db68eb77871bfd2f

Bug 1445662 landed in that timeframe. ni on :kats

Top 10 frames of crashing thread:

0 xul.dll static struct mozilla::layers::CompositorBridgeParent::LayerTreeState* mozilla::layers::GetStateForRoot gfx/layers/ipc/CompositorBridgeParent.cpp:2190
1 xul.dll mozilla::layers::CompositorBridgeParent::GetApzcTreeManagerParentForRoot gfx/layers/ipc/CompositorBridgeParent.cpp:2203
2 xul.dll mozilla::layers::RemoteContentController::CancelAutoscrollCrossProcess gfx/layers/ipc/RemoteContentController.cpp:387
3 xul.dll mozilla::layers::AutoscrollAnimation::Cancel gfx/layers/apz/src/AutoscrollAnimation.cpp:94
4 xul.dll mozilla::layers::AsyncPanZoomController::CancelAnimation gfx/layers/apz/src/AsyncPanZoomController.cpp:3094
5 xul.dll mozilla::layers::AsyncPanZoomController::Destroy gfx/layers/apz/src/AsyncPanZoomController.cpp:853
6 xul.dll mozilla::layers::HitTestingTreeNode::Destroy gfx/layers/apz/src/HitTestingTreeNode.cpp:69
7 xul.dll mozilla::layers::APZCTreeManager::ClearTree gfx/layers/apz/src/APZCTreeManager.cpp:2112
8 xul.dll mozilla::detail::RunnableMethodImpl<nsIDocument*, void  xpcom/threads/nsThreadUtils.h:1215
9 xul.dll mozilla::layers::APZUpdater::RunOnUpdaterThread gfx/layers/apz/src/APZUpdater.cpp:214

=============================================================
Flags: needinfo?(bugmail)
Thanks!

I have a patch waiting for bug 1452845 which will probably fix this by moving the ClearTree() call to happen earlier.
Assignee: nobody → bugmail
Depends on: 1452845
Flags: needinfo?(bugmail)
Actually I might as well put it on this bug.
Blocks: 1452845
No longer depends on: 1452845
To be honest I'm not really sure how bug 1445662 introduced this, but it's the most likely bug in that range.
Blocks: 1445662
Whiteboard: [gfx-noted]
Priority: -- → P1
Comment on attachment 8968273 [details]
Bug 1454430 - Ensure the ClearTree task runs before we shut down webrender.

https://reviewboard.mozilla.org/r/236958/#review242920
Attachment #8968273 - Flags: review?(nical.bugzilla) → review+
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/de79e5a6aa53
Ensure the ClearTree task runs before we shut down webrender. r=nical
https://hg.mozilla.org/mozilla-central/rev/de79e5a6aa53
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.