Closed Bug 1454455 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 10490 - Implement selectable AudioParam rate

Categories

(Core :: Web Audio, enhancement, P4)

enhancement

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: wptsync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 10490 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/w3c/web-platform-tests/pull/10490
Details from upstream follow.

Raymond Toy <rtoy@chromium.org> wrote:
>  Implement selectable AudioParam rate
>  
>  AudioParam has a new attribute, automationRate, to allow the user to choose whether
>  the AudioParam is "a-rate" or "k-rate".  Add support for setting and getting
>  the attribute.
>  
>  Spec: https://webaudio.github.io/web-audio-api/#dom-audioparam-automationrate
>  Intent: https://groups.google.com/a/chromium.org/d/msg/blink-dev/extLjVzLw7s/9XUZvQqcBQAJ
>  
>  Bug: 828947
>  Change-Id: Ibb9fe8bc0dedf3cfdcf33727734b5d66e5a7ca2f
>  Reviewed-on: https://chromium-review.googlesource.com/945076
>  WPT-Export-Revision: 46fcceae1c15ac4101c0f286b08a7d2aa82fb041
Component: web-platform-tests → Web Audio
Product: Testing → Core
Try push failed: decision task returned error
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Ran 7 tests and 108 subtests
OK     : 6
PASS   : 76
FAIL   : 32
TIMEOUT: 1

New tests that have failures or other problems:
/webaudio/the-audio-api/the-audioparam-interface/k-rate-biquad.html
    # AUDIT TASK RUNNER FINISHED: 5 out of 5 tasks were failed.: FAIL
    < [Biquad k-rate AudioParams (all)] 1 out of 11 assertions were failed.: FAIL
    < [Biquad k-rate Q] 1 out of 8 assertions were failed.: FAIL
    < [Biquad k-rate detune] 1 out of 8 assertions were failed.: FAIL
    < [Biquad k-rate frequency] 1 out of 8 assertions were failed.: FAIL
    < [Biquad k-rate gain] 1 out of 8 assertions were failed.: FAIL
    X All k-rate params: Difference between a-rate and k-rate BiquadFilterNode should have contain at least one value different from 0.: FAIL
    X k-rate Q: Difference between a-rate and k-rate BiquadFilterNode should have contain at least one value different from 0.: FAIL
    X k-rate detune: Difference between a-rate and k-rate BiquadFilterNode should have contain at least one value different from 0.: FAIL
    X k-rate frequency: Difference between a-rate and k-rate BiquadFilterNode should have contain at least one value different from 0.: FAIL
    X k-rate gain: Difference between a-rate and k-rate BiquadFilterNode should have contain at least one value different from 0.: FAIL
/webaudio/the-audio-api/the-audioparam-interface/k-rate-constant-source.html
    # AUDIT TASK RUNNER FINISHED: 1 out of 1 tasks were failed.: FAIL
    < [ConstantSource k-rate offset] 5 out of 5 assertions were failed.: FAIL
    X Difference between a-rate and k-rate outputs should have contain at least one value different from 0.: FAIL
    X k-rate output [0: 127]: Expected 0 for all values but found 127 unexpected values: 
	Index	Actual
	[1]	0.01953125
	[2]	0.0390625
	[3]	0.05859375
	[4]	0.078125
	...and 123 more errors.: FAIL
    X k-rate output [128: 255]: Expected 2.5 for all values but found 127 unexpected values: 
	Index	Actual
	[1]	2.51953125
	[2]	2.5390625
	[3]	2.55859375
	[4]	2.578125
	...and 123 more errors.: FAIL
    X k-rate output [256: 383]: Expected 5 for all values but found 127 unexpected values: 
	Index	Actual
	[1]	5.01953125
	[2]	5.0390625
	[3]	5.05859375
	[4]	5.078125
	...and 123 more errors.: FAIL
    X k-rate output [384: 511]: Expected 7.5 for all values but found 127 unexpected values: 
	Index	Actual
	[1]	7.51953125
	[2]	7.5390625
	[3]	7.55859375
	[4]	7.578125
	...and 123 more errors.: FAIL
/webaudio/the-audio-api/the-audioparam-interface/k-rate-delay.html
    # AUDIT TASK RUNNER FINISHED: 1 out of 1 tasks were failed.: FAIL
    < [Test k-rate DelayNode] 1 out of 8 assertions were failed.: FAIL
    X DelayNode: Difference between a-rate and k-rate DelayNode should have contain at least one value different from 0.: FAIL
/webaudio/the-audio-api/the-audioparam-interface/k-rate-gain.html
    # AUDIT TASK RUNNER FINISHED: 1 out of 1 tasks were failed.: FAIL
    < [Test k-rate GainNode] 1 out of 8 assertions were failed.: FAIL
    X GainNode: Difference between a-rate and k-rate GainNode should have contain at least one value different from 0.: FAIL
/webaudio/the-audio-api/the-audioparam-interface/k-rate-oscillator.html
    # AUDIT TASK RUNNER FINISHED: 2 out of 2 tasks were failed.: FAIL
    < [Oscillator k-rate detune] 1 out of 1 assertions were failed.: FAIL
    < [Oscillator k-rate frequency] 1 out of 1 assertions were failed.: FAIL
    X k-rate detune: Difference between a-rate and k-rate outputs should have contain at least one value different from 0.: FAIL
    X k-rate frequency: Difference between a-rate and k-rate outputs should have contain at least one value different from 0.: FAIL
/webaudio/the-audio-api/the-audioparam-interface/k-rate-panner.html: TIMEOUT
/webaudio/the-audio-api/the-audioparam-interface/k-rate-stereo-panner.html
    # AUDIT TASK RUNNER FINISHED: 1 out of 1 tasks were failed.: FAIL
    < [Test k-rate StereoPannerNode] 1 out of 8 assertions were failed.: FAIL
    X StereoPannerNode: Difference between a-rate and k-rate StereoPannerNode should have contain at least one value different from 0.: FAIL
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/92696c3b1021
[wpt PR 10490] - Implement selectable AudioParam rate, a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/44d8aff8e61f
[wpt PR 10490] - Update wpt metadata, a=testonly
https://hg.mozilla.org/mozilla-central/rev/92696c3b1021
https://hg.mozilla.org/mozilla-central/rev/44d8aff8e61f
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.