Closed Bug 1454486 Opened 2 years ago Closed 2 years ago

Update eBay icon

Categories

(Firefox :: Search, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 61
Tracking Status
firefox59 --- wontfix
firefox60 - fixed
firefox61 --- fixed

People

(Reporter: mkaply, Assigned: mkaply)

Details

Attachments

(2 files)

We don't think people realize the suitcase is ebay.

Replacing with the word eBay. 

[Tracking Requested - why for this release]: Trying to increase eBay use.
Assignee: nobody → mozilla
Comment on attachment 8968343 [details]
Bug 1454486 - Update eBay icon.

https://reviewboard.mozilla.org/r/237020/#review242874

Image doesn't open for me locally after I import your patch from mozreview.

I tried dragging it to Firefox, and it resulted in a beachball (had to kill the browser completely).
Attachment #8968343 - Flags: review?(francesco.lodolo) → review-
Note: we've been here before. Some the DATA URI loads within Firefox, but I don't think it makes sense to have an .ico that nobody can open in the tree

data:image/x-icon;base64,AAABAAIAEBAAAAAAAAB6AQAAJgAAACAgAAAAAAAAQgMAAKABAACJUE5HDQoaCgAAAA1JSERSAAAAEAAAABAIBgAAAB/z/2EAAAFBSURBVDjLtZPdK0MBGIf3J5Babhx3rinFBWuipaUskX9DYvkopqgV90q5UJpyp0OKrUWM2VrRsS9D0zZKHGaOnW1nj4vtypVtPPe/533r9746QAAOAJXfo5Yzgg44pHrcugon/6Sgo0b+XuAOZ2iZiVQmyPoDpIwmUkYTzqM7GsdDdC7F6Lbf8pzOkfWOouzqeZem2b+2AqAV8zjD8yVBqqcf2b7C66yNiMGMfixIQSvi8Mp0LEbR5ADq1QSKWM+Gx0RC9nOZ2GLzwlIWdPWiuNzk4w/EpThNkyEAXKEP2ud8KGId2sspilhPMrmNwzfCuqePr/xbSfC5I/I0MMSj2YJ3z49gDdO2cEOrLUowJpE9G0QRG1ClKbR0EIdvmOPYcnUtnN+vsnZiQC1k/qnGagQ1n3LNzySUJZVskitnmr8BlQG7T2hvgxsAAAAASUVORK5CYIKJUE5HDQoaCgAAAA1JSERSAAAAIAAAACAIBgAAAHN6evQAAAMJSURBVFjD7ZddSFNhGMeHXXQTZFFCWfR1pRhUECQlBdWVToo+6KYu1KigtDASG5qUfZgFZvahEDosECPDktKZS1FL+1DRnEvdUptjug91X2dnZzv/3vO6OZbWnR4v9sADL+fs7P97/s/znu2VAJD4UkpSSdKG+QubTyPBr+sXz8XCR64fIAHihVTis0SsUAoAVhEBrBKIHCGAEMB/ARi3F5LkbpS2WMRzYEEBXC2tsD6T03R9agsCGLNyqPw6CXmrBT06JvhbPHZwmkdwtR0B138PPKOHgzXD5jLAy3tmibo4K9weZwDAazJj/FQKRnfugfHMeRiTz0K3Ixam1HQKcPC+Fisu9NK1P08Uj4DleHgMdXC+WQ7nu3UEOhFMfTQcVUvQ1H4IN2sj8H2k7K+2TqCc3GseyA8AmDOzMBq7D9bS8sAr6nEJdNt3UbHVF1XQGtmZew8bTPT6tWoD3KpsUvlR8NxUoEICMvl6KQo+xqCwcRs4T8Ax5c8bFExjbAgAjO7aS8VsLypgq3g5nWStjztAhWRVhqAqeB6IuKTClkw1eNYEbrCQQBwD8yGGOsAooogLYejQPKBi7UPF9DkH+ezd+o141ZkUPAOC+L9SAMivNc7q46YMNSLTe4n1kaQF4XD3ZIDTPgU3XEYciKcAHrsGJS1xKFBGgyVzouiT4VbdGhjt/cEA5isyKsaz7jl3we7bg7Rqf6j0LoSldON4wWcqJDgQNGTN++l13vELA+MK6kKd6iryFOvxtidt9i5gO7owdjKJQliflNAU1pas6xQgnAzg1ux+lJEdILixNr0Pq9JUUA8NwVG9DM73G0jlcnh+V4BpjIWzJmIGQIjnXw5TiDuKSEwxurm3ITc8DNO51BnrLbIcsrW0dNA6RxgUKU1UdGVqLy5X6qGzTLvlnewiBZyGs3Yz6X8UeaYI3olvZDhzwLumZ+eHvooCCC0Q5VUsb4unwycM4YIDqA01tPqmgbzQr2EIYPECiPm33LYoDiZSsY9moh9O/Znoa4d9HkXtPg2pX/cPKCoRQ+ocZa4AAAAASUVORK5CYII=

Even opening this in Firefox, then saving the image, results in a file that I can't open anywhere (Preview, Pixelmator).
Attached image ebay_v2.ico
Interestingly enough, Gimp on Linux manages to load the file, and export a working image.
I always forget about the icon thing.

> I tried dragging it to Firefox, and it resulted in a beachball (had to kill the browser completely).

That seems bad. I wonder if that happens when it loads from a web page?
Comment on attachment 8968343 [details]
Bug 1454486 - Update eBay icon.

https://reviewboard.mozilla.org/r/237020/#review243046
Attachment #8968343 - Flags: review?(francesco.lodolo) → review+
(In reply to Mike Kaply [:mkaply] from comment #6)
> I always forget about the icon thing.
> 
> > I tried dragging it to Firefox, and it resulted in a beachball (had to kill the browser completely).
> 
> That seems bad. I wonder if that happens when it loads from a web page?

I don't think so. I tried converting into a data URI via 
http://freeonlinetools24.com/base64-image

And that loads when pasted in the address bar. I've also tried again with beta, and it worked, not sure if it was a one-time issue.
Comment on attachment 8968343 [details]
Bug 1454486 - Update eBay icon.

Approval Request Comment
[Feature/Bug causing the regression]: Update eBay icon
[User impact if declined]: eBay icon is not recognizable
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: Not yet
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: No
[Is the change risky?]: No
[Why is the change risky/not risky?]: Just an icon change
[String changes made/needed]: None

We believe the eBay suitcase icon isn't recognized by users, so we're moving to an older icon that has eBay in it.
Attachment #8968343 - Flags: approval-mozilla-beta?
https://hg.mozilla.org/mozilla-central/rev/bbe44fc94f51
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
Comment on attachment 8968343 [details]
Bug 1454486 - Update eBay icon.

icon change, approved for 60.0b14
Attachment #8968343 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
(In reply to Mike Kaply [:mkaply] from comment #0)

> ... Trying to increase eBay use.

Just curious on the why for this one.
> ... Trying to increase eBay use.

We have partner relationship with eBay, so we'd love to see it used more. But it's really about making people aware that we've integrated eBay again.
You need to log in before you can comment on or make changes to this bug.