1454491 - Incorrect string is replaced

Status: RESOLVED WORKSFORME

(DevTools :: Console, defect)

Description

[ivanov]

Attachment: firefox.png

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/65.0.3325.181 Safari/537.36
Firefox for Android

Steps to reproduce:

console.log('%c%s', `

                background: #f4f4f4;
                border: 1px solid #ddd;
                border-left: 3px solid #f36d33;
                color: #666;
                page-break-inside: avoid;
                font-family: monospace;
                font-size: 15px;
                line-height: 1.6;
                margin: 1.6em 5px;
                max-width: 100%;
                overflow: auto;
                padding: 1em 1.5em;
                display: block;
                word-wrap: break-word;

`, `

@Component({ .. })
export class AppComponent { .. }

`);


Actual results:

One line merges the text


Expected results:

Chrome good work:
https://habrastorage.org/webt/7c/k6/ne/7ck6ney5wh0srs-o0uxu_ybjwkm.png

Comment 1

[ivanov]

console.log(`%c

@Component({ .. })
export class AppComponent { .. }

`, `

                background: #f4f4f4;
                border: 1px solid #ddd;
                border-left: 3px solid #f36d33;
                color: #666;
                page-break-inside: avoid;
                font-family: monospace;
                font-size: 15px;
                line-height: 1.6;
                margin: 1.6em 5px;
                max-width: 100%;
                overflow: auto;
                padding: 1em 1.5em;
                display: block;
                word-wrap: break-word;

`);

Comment 2

[Johann Hofmann [:johannh]]

I can't reproduce this in the latest Nightly and I don't understand the security aspect of it.

Would you mind testing this again in Nightly and explaining why you think this is a security issue?

Comment 3

[ivanov]

I'm not right to have something.
This is not a security issue.

I just wanted to point out that this is a bug with a value of CSS in the console.
Because different browsers have different behaviors

Comment 4

[Johann Hofmann [:johannh]]

Thanks! I'll leave this to devtools folks to triage...

Comment 5

[Nicolas Chevobbe [:nchevobbe]]

Attachment: chrome_ff.png

Hey Ivanov,

Could you tell me if there's still an issue ? 
I can't see any difference between Chrome and Firefox with your example.

Comment 6

[ivanov]

The problem is still observed

https://habrastorage.org/webt/14/a6/kf/14a6kf0fqhcbmsrvvmwc_xsxhfs.png
https://habrastorage.org/webt/xp/gz/lf/xpgzlfhaxywxdolgdhjf4jnjup0.png

Comment 7

[Nicolas Chevobbe [:nchevobbe]]

This is ff 57, I think release is in 59 now ? Could you try to update and see if it's still an issue ?
Also, if you can try on Firefox Nightly and check the issue isn't here anymore that would be great :)

Comment 8

[ivanov]

The problem is still observed FF 59

https://habrastorage.org/webt/k7/cx/cn/k7cxcnvfso0v_cmsvy1bj_fegke.png

Comment 9

[Nicolas Chevobbe [:nchevobbe]]

Just tested in Firefox 60 and it works as expected