Closed
Bug 1454511
Opened 6 years ago
Closed 6 years ago
widen valgrind suppressions for css parsing
Categories
(Core :: CSS Parsing and Computation, enhancement)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla61
Tracking | Status | |
---|---|---|
firefox61 | --- | fixed |
People
(Reporter: bholley, Assigned: bholley)
References
Details
Attachments
(1 file)
1.47 KB,
patch
|
n.nethercote
:
review+
|
Details | Diff | Splinter Review |
Splitting this out of bug 1454030 because it's still waiting for review.
Assignee | ||
Comment 1•6 years ago
|
||
The existing suppression tries to be specific about the callstack that arrives at the function, but that breaks when we rejigger the machinery up the callstack. In practice, the existing suppressions cover most of the ways we would arrive at selector parsing, and so I think the specificity here is more trouble than it's worth. r? njn or julien, whoever gets to it first. MozReview-Commit-ID: 2k52xq64SQX
Attachment #8968349 -
Flags: review?(n.nethercote)
Attachment #8968349 -
Flags: review?(jseward)
Updated•6 years ago
|
Attachment #8968349 -
Flags: review?(n.nethercote)
Attachment #8968349 -
Flags: review?(jseward)
Attachment #8968349 -
Flags: review+
Pushed by bholley@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/bb4fe8662ae3 Widen valgrind suppression for selector parsing. r=njn
Comment 3•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/bb4fe8662ae3
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in
before you can comment on or make changes to this bug.
Description
•