Closed Bug 1454622 Opened Last year Closed 3 months ago

Change DOMQuad bounds to getBounds() as per specification

Categories

(Core :: DOM: Core & HTML, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla69
Tracking Status
firefox61 --- wontfix
firefox69 --- fixed

People

(Reporter: zcorpan, Assigned: saschanaz)

Details

(Keywords: dev-doc-needed, site-compat)

Attachments

(1 file)

Spec: https://drafts.fxtf.org/geometry/#dom-domquad-getbounds

Gecko implements .bounds instead of .getBounds(). Chromium and WebKit implement .getBounds().

Test that needs fixing to change .bounds to .getBounds():
http://w3c-test.org/css/geometry/DOMQuad-001.html

Test that uses getBounds():
http://w3c-test.org/css/geometry/DOMQuad-002.html

Should also add .bounds to http://w3c-test.org/css/geometry/historical.html
This isn't just a naming matter.  The two getters have totally different semantics ([SameObject] vs [NewObject]).  Would need to carefully audit all code using this getter to see whether it's OK with that change.

In practice, we should probably ship getBounds(), convert internal consumers, then work on telemetry for .bounds or something...
Priority: -- → P3
In bug 1186265, I'm marking .bounds as deprecated and adding telemetry to give us an idea of how used it is. Hopefully we'll be able to remove it in a few releases.
Component: DOM → DOM: Core & HTML

I suspect once this is fixed we can use [Default] for the toJSON method on DOMQuad.

The bounds attribute has been deprecated and shown zero use, and thus this change removes it.

Should an intent to unship published?

Flags: needinfo?(bzbarsky)
Keywords: checkin-needed

Yes, please!

Note that I tried landing the changes and they failed to apply to tip of autoland, so you may need to merge to tip....

Flags: needinfo?(bzbarsky)
Keywords: checkin-needed
Keywords: checkin-needed
Assignee: nobody → saschanaz

Pushed by nbeleuzu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/41dbf1cd1fbf
Remove DOMQuad bounds attribute r=bzbarsky

Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla69

On MDN we only mention getBounds(), so I think this'll just require a mention in the Fx69 rel notes when the time comes.

Keywords: dev-doc-needed
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/17693 for changes under testing/web-platform/tests
Upstream PR merged
You need to log in before you can comment on or make changes to this bug.