1454622 - Change DOMQuad bounds to getBounds() as per specification

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement, P3)

Description

[Simon Pieters [:zcorpan]]

Spec: https://drafts.fxtf.org/geometry/#dom-domquad-getbounds

Gecko implements .bounds instead of .getBounds(). Chromium and WebKit implement .getBounds().

Test that needs fixing to change .bounds to .getBounds():
http://w3c-test.org/css/geometry/DOMQuad-001.html

Test that uses getBounds():
http://w3c-test.org/css/geometry/DOMQuad-002.html

Should also add .bounds to http://w3c-test.org/css/geometry/historical.html

Comment 1

[Boris Zbarsky [:bzbarsky]]

This isn't just a naming matter.  The two getters have totally different semantics ([SameObject] vs [NewObject]).  Would need to carefully audit all code using this getter to see whether it's OK with that change.

In practice, we should probably ship getBounds(), convert internal consumers, then work on telemetry for .bounds or something...

Comment 2

[Blake Kaplan (:mrbkap) (inactive)]

In bug 1186265, I'm marking .bounds as deprecated and adding telemetry to give us an idea of how used it is. Hopefully we'll be able to remove it in a few releases.

Comment 3

[Blake Kaplan (:mrbkap) (inactive)]

https://telemetry.mozilla.org/new-pipeline/dist.html#!cumulative=0&end_date=2018-08-02&keys=__none__!__none__!__none__&max_channel_version=nightly%252F63&measure=USE_COUNTER2_DEPRECATED_DOMQuadBoundsAttr_PAGE&min_channel_version=nightly%252F60&processType=*&product=Firefox&sanitize=1&sort_keys=submissions&start_date=2018-06-25&table=0&trim=1&use_submission_date=0 looks pretty unused.

Comment 4

[Boris Zbarsky [:bzbarsky]]

I suspect once this is fixed we can use [Default] for the toJSON method on DOMQuad.

Comment 5

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1454622: Remove DOMQuad bounds attribute

The bounds attribute has been deprecated and shown zero use, and thus this change removes it.

Comment 6

[Kagami Rosylight [:saschanaz] (they/them)]

Should an intent to unship published?

Comment 7

[Boris Zbarsky [:bzbarsky]]

Yes, please!

Note that I tried landing the changes and they failed to apply to tip of autoland, so you may need to merge to tip....

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/41dbf1cd1fbf
Remove DOMQuad bounds attribute r=bzbarsky

Comment 9

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/41dbf1cd1fbf

Comment 10

[Kohei Yoshino]

Posted site compatibility note: https://www.fxsitecompat.dev/en-CA/docs/2019/domquad-bounds-has-been-dropped-in-favour-of-getbounds/

Comment 11

[Chris Mills [:cmills]]

On MDN we only mention getBounds(), so I think this'll just require a mention in the Fx69 rel notes when the time comes.

Comment 12

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/17693 for changes under testing/web-platform/tests

Comment 13

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged