Closed Bug 1454627 Opened 7 years ago Closed 7 years ago

Failed to request permissions inside the handler of the menu item

Categories

(WebExtensions :: Frontend, defect)

60 Branch
defect
Not set
normal

Tracking

(firefox-esr60 fixed, firefox62 fixed, firefox63 fixed)

RESOLVED FIXED
mozilla63
Iteration:
63.3 - Aug 6
Tracking Status
firefox-esr60 --- fixed
firefox62 --- fixed
firefox63 --- fixed

People

(Reporter: eight04, Assigned: robwu)

References

Details

Attachments

(3 files)

User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:60.0) Gecko/20100101 Firefox/60.0 Build ID: 20180412172954 Steps to reproduce: I encountered this bug while developing an extension: 1. Create a webextension. 2. In the background page, create a menu item and call permissions.request() from the onclick handler. Demo: https://github.com/eight04/webextension-test/tree/permission Actual results: An error occurred: Error: permissions.request may only be called from a user input handler If the handler is registered through menus.onClicked ("Test 2" in the demo): Error: An unexpected error occurred Expected results: Quote from MDN: > The request can only be made inside the handler for a user action, such as > ... selecting its context menu item https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/permissions/request
I'm not exactly certain if this is the correct component, so please correct if this is not the case. Thanks.
Component: Untriaged → WebExtensions: Request Handling
Product: Firefox → Toolkit
Status: UNCONFIRMED → RESOLVED
Closed: 7 years ago
Resolution: --- → DUPLICATE
Assignee: nobody → tomica
Status: RESOLVED → REOPENED
Ever confirmed: true
Resolution: DUPLICATE → ---
Component: WebExtensions: Request Handling → WebExtensions: Frontend
See bug 1422605 comment 17, this is a another related issue.
Blocks: 1422605
Product: Toolkit → WebExtensions
Assignee: tomica → rob
Blocks: 1381305
Iteration: --- → 63.3 - Aug 6
Attachment #8995565 - Flags: review?(mixedpuppy) → review+
Attachment #8995566 - Flags: review?(mixedpuppy) → review+
Pushed by rob@robwu.nl: https://hg.mozilla.org/integration/autoland/rev/9661870b7453 Re-enable browser_ext_user_events.js (bug 1381305) r=mixedpuppy https://hg.mozilla.org/integration/autoland/rev/3285f664c261 Run "onclick" event of menu with user input r=mixedpuppy
Backed out 2 changesets (bug 1454627) for frequently failing browser-chrome at browser/components/extensions/test/browser/test-oop-extensions/browser_ext_user_events.js Backout: https://hg.mozilla.org/integration/autoland/rev/01a86884bacb78670e48f1a2660e33f65e062b19 Failure push: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=3285f664c26122df3903d7a99eddf2cca8953f72 Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=190986279&repo=autoland&lineNumber=34848 15:51:41 INFO - TEST-PASS | browser/components/extensions/test/browser/test-oop-extensions/browser_ext_user_events.js | request() succeeded when called from context menu in onClicked - 15:51:41 INFO - Buffered messages finished 15:51:41 INFO - TEST-UNEXPECTED-FAIL | browser/components/extensions/test/browser/test-oop-extensions/browser_ext_user_events.js | Test timed out - 15:51:41 INFO - Not taking screenshot here: see the one that was previously logged 15:51:41 INFO - TEST-UNEXPECTED-FAIL | browser/components/extensions/test/browser/test-oop-extensions/browser_ext_user_events.js | no tasks awaiting on messages - Got ["request"], expected [] 15:51:41 INFO - Stack trace: 15:51:41 INFO - chrome://mochikit/content/browser-test.js:test_is:1305 15:51:41 INFO - chrome://mochikit/content/tests/SimpleTest/ExtensionTestUtils.js:ExtensionTestUtils.loadExtension/<:31 15:51:41 INFO - chrome://mochikit/content/browser-test.js:nextTest:705 15:51:41 INFO - chrome://mochikit/content/browser-test.js:timeoutFn:1200 15:51:41 INFO - setTimeout handler*chrome://mochikit/content/browser-test.js:Tester_execTest:1162 15:51:41 INFO - chrome://mochikit/content/browser-test.js:nextTest/<:996 15:51:41 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:795 15:51:41 INFO - Not taking screenshot here: see the one that was previously logged 15:51:41 INFO - TEST-UNEXPECTED-FAIL | browser/components/extensions/test/browser/test-oop-extensions/browser_ext_user_events.js | Extension left running at test shutdown - 15:51:41 INFO - Stack trace: 15:51:41 INFO - chrome://mochikit/content/tests/SimpleTest/ExtensionTestUtils.js:ExtensionTestUtils.loadExtension/<:109 15:51:41 INFO - chrome://mochikit/content/browser-test.js:nextTest:705 15:51:41 INFO - chrome://mochikit/content/browser-test.js:timeoutFn:1200 15:51:41 INFO - setTimeout handler*chrome://mochikit/content/browser-test.js:Tester_execTest:1162 15:51:41 INFO - chrome://mochikit/content/browser-test.js:nextTest/<:996 15:51:41 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:795 15:51:41 INFO - Console message: Warning: attempting to write 27955 bytes to preference extensions.webextensions.uuids. This is bad for general performance and memory usage. Such an amount of data should rather be written to an external file. This preference will not be sent to any content processes. 15:51:41 INFO - GECKO(2079) | MEMORY STAT | vsize 5617MB | residentFast 744MB | heapAllocated 144MB 15:51:41 INFO - TEST-OK | browser/components/extensions/test/browser/test-oop-extensions/browser_ext_user_events.js | took 90399ms 15:51:41 INFO - Not taking screenshot here: see the one that was previously logged 15:51:41 INFO - TEST-UNEXPECTED-FAIL | browser/components/extensions/test/browser/test-oop-extensions/browser_ext_user_events.js | Found a tab after previous test timed out: about:addons - 15:51:41 INFO - GECKO(2079) | ++DOCSHELL 0x117624000 == 1 [pid = 2084] [id = {0b274640-dfea-0e4b-b2c3-bb5f727706cc}] 15:51:41 INFO - GECKO(2079) | ++DOMWINDOW == 1 (0x12938c400) [pid = 2084] [serial = 207] [outer = 0x0] 15:51:41 INFO - GECKO(2079) | ++DOMWINDOW == 2 (0x1176ef400) [pid = 2084] [serial = 208] [outer = 0x12938c400] 15:51:41 INFO - checking window state
Flags: needinfo?(rob)
Comment on attachment 8996336 [details] Bug 1454627 - Fix timing issue in browser_ext_user_events.js https://reviewboard.mozilla.org/r/260472/#review267550
Attachment #8996336 - Flags: review?(mixedpuppy) → review+
Flags: needinfo?(rob)
Pushed by rob@robwu.nl: https://hg.mozilla.org/integration/autoland/rev/22de883763ac Re-enable browser_ext_user_events.js (bug 1381305) r=mixedpuppy https://hg.mozilla.org/integration/autoland/rev/44b38de7dc3d Run "onclick" event of menu with user input r=mixedpuppy https://hg.mozilla.org/integration/autoland/rev/38d9cbe6e3d2 Fix timing issue in browser_ext_user_events.js r=mixedpuppy
Backed out 3 changesets (Bug 1454627) for test-oop-extensions/browser_ext_user_events.js failures. Push with failures:https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=38d9cbe6e3d20e9099807a00bf1335a8451a9764 Backout link: https://hg.mozilla.org/integration/autoland/rev/c6b4c044da81ae4276028bedc442f28f5ebb1453 Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=191224490&repo=autoland&lineNumber=32281 13:46:28 INFO - TEST-PASS | browser/components/extensions/test/browser/test-oop-extensions/browser_ext_user_events.js | notification panel open - 13:46:28 INFO - TEST-PASS | browser/components/extensions/test/browser/test-oop-extensions/browser_ext_user_events.js | request() did not throw when called from context menu in onClicked - 13:46:28 INFO - TEST-PASS | browser/components/extensions/test/browser/test-oop-extensions/browser_ext_user_events.js | request() succeeded when called from context menu in onClicked - 13:46:28 INFO - Buffered messages finished 13:46:28 INFO - TEST-UNEXPECTED-FAIL | browser/components/extensions/test/browser/test-oop-extensions/browser_ext_user_events.js | Test timed out - 13:46:28 INFO - Not taking screenshot here: see the one that was previously logged 13:46:28 INFO - TEST-UNEXPECTED-FAIL | browser/components/extensions/test/browser/test-oop-extensions/browser_ext_user_events.js | no tasks awaiting on messages - Got ["request"], expected [] 13:46:28 INFO - Stack trace: 13:46:28 INFO - chrome://mochikit/content/browser-test.js:test_is:1305 13:46:28 INFO - chrome://mochikit/content/tests/SimpleTest/ExtensionTestUtils.js:ExtensionTestUtils.loadExtension/<:31 13:46:28 INFO - chrome://mochikit/content/browser-test.js:nextTest:705 13:46:28 INFO - chrome://mochikit/content/browser-test.js:timeoutFn:1200 13:46:28 INFO - setTimeout handler*chrome://mochikit/content/browser-test.js:Tester_execTest:1162 13:46:28 INFO - chrome://mochikit/content/browser-test.js:nextTest/<:996 13:46:28 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:795 13:46:28 INFO - Not taking screenshot here: see the one that was previously logged 13:46:28 INFO - TEST-UNEXPECTED-FAIL | browser/components/extensions/test/browser/test-oop-extensions/browser_ext_user_events.js | Extension left running at test shutdown - 13:46:28 INFO - Stack trace: 13:46:28 INFO - chrome://mochikit/content/tests/SimpleTest/ExtensionTestUtils.js:ExtensionTestUtils.loadExtension/<:109 13:46:28 INFO - chrome://mochikit/content/browser-test.js:nextTest:705 13:46:28 INFO - chrome://mochikit/content/browser-test.js:timeoutFn:1200 13:46:28 INFO - setTimeout handler*chrome://mochikit/content/browser-test.js:Tester_execTest:1162 13:46:28 INFO - chrome://mochikit/content/browser-test.js:nextTest/<:996 13:46:28 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:795 13:46:28 INFO - Console message: Warning: attempting to write 28115 bytes to preference extensions.webextensions.uuids. This is bad for general performance and memory usage. Such an amount of data should rather be written to an external file. This preference will not be sent to any content processes. 13:46:28 INFO - GECKO(2001) | MEMORY STAT | vsize 5635MB | residentFast 755MB | heapAllocated 144MB 13:46:28 INFO - TEST-OK | browser/components/extensions/test/browser/test-oop-extensions/browser_ext_user_events.js | took 90419ms 13:46:28 INFO - Not taking screenshot here: see the one that was previously logged 13:46:28 INFO - TEST-UNEXPECTED-FAIL | browser/components/extensions/test/browser/test-oop-extensions/browser_ext_user_events.js | Found a tab after previous test timed out: about:addons - 13:46:28 INFO - GECKO(2001) | ++DOCSHELL 0x11195f800 == 1 [pid = 2006] [id = {fcb56f42-f989-9540-b028-305965070ed0}] 13:46:28 INFO - GECKO(2001) | ++DOMWINDOW == 1 (0x11ced1600) [pid = 2006] [serial = 206] [outer = 0x0] 13:46:28 INFO - GECKO(2001) | ++DOMWINDOW == 2 (0x10a9f2800) [pid = 2006] [serial = 207] [outer = 0x11ced1600]
Status: REOPENED → RESOLVED
Closed: 7 years ago7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Flags: needinfo?(rob)
Pushed by rob@robwu.nl: https://hg.mozilla.org/integration/autoland/rev/64e2944b635b Re-enable browser_ext_user_events.js (bug 1381305) r=mixedpuppy https://hg.mozilla.org/integration/autoland/rev/50114fce0886 Run "onclick" event of menu with user input r=mixedpuppy https://hg.mozilla.org/integration/autoland/rev/3a4b606f79ae Fix timing issue in browser_ext_user_events.js r=mixedpuppy
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Target Milestone: mozilla63 → ---
Flags: needinfo?(rob)
Status: REOPENED → RESOLVED
Closed: 7 years ago7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: