Closed Bug 1454709 Opened 6 years ago Closed 6 years ago

Don't keep MediaControlService running on unsupported Android versions

Categories

(Firefox for Android Graveyard :: Audio/Video, enhancement)

Firefox 61
All
Android
enhancement
Not set
normal

Tracking

(firefox61 fixed)

RESOLVED FIXED
Firefox 61
Tracking Status
firefox61 --- fixed

People

(Reporter: JanH, Assigned: JanH)

References

Details

Attachments

(1 file, 1 obsolete file)

      No description provided.
Comment on attachment 8968620 [details]
Bug 1454709 - Don't run MediaControlService on unsupported Android versions.

https://reviewboard.mozilla.org/r/237314/#review243394

I think I'd just roll this patch into the other one. The patch doesn't seem to match the commit message IMO.
Attachment #8968620 - Flags: review?(snorp) → review+
Comment on attachment 8968621 [details]
Bug 1454709 - Part 2 - Don't start MediaControlService un unsupported OS versions in the first place.

https://reviewboard.mozilla.org/r/237316/#review243396
Attachment #8968621 - Flags: review?(snorp) → review+
Comment on attachment 8968620 [details]
Bug 1454709 - Don't run MediaControlService on unsupported Android versions.

https://reviewboard.mozilla.org/r/237314/#review243394

I sort of see why you might mean that, but just to explain things more precisely for the record:
- Without this patch, when the service is starting (because somebody sent a corresponding Intent) on an unsupported Android version, we return early from initialise, but never call `stopSelf()`, so the service nominally keeps on running, even though it won't be able to do anything interesting with `mInitialize` being false.
- With this patch, if anybody causes the service to start up, we not only just skip initialisation if the Android version is too low, but also shut the service down again by calling `stopSelf()` before returning from `onCreate()`.
Attachment #8968621 - Attachment is obsolete: true
Pushed by mozilla@buttercookie.de:
https://hg.mozilla.org/integration/autoland/rev/13f330a9dba1
Don't run MediaControlService on unsupported Android versions. r=snorp
https://hg.mozilla.org/mozilla-central/rev/13f330a9dba1
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.