1454709 - Don't keep MediaControlService running on unsupported Android versions

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Audio/Video, enhancement)

Comment 1

[Jan Henning [:JanH]]

Attachment: Bug 1454709 - Don't run MediaControlService on unsupported Android versions.

Review commit: https://reviewboard.mozilla.org/r/237314/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/237314/

Comment 2

[Jan Henning [:JanH]]

Attachment: Bug 1454709 - Part 2 - Don't start MediaControlService un unsupported OS versions in the first place.

Review commit: https://reviewboard.mozilla.org/r/237316/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/237316/

Comment 3

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 8968620 [details]
Bug 1454709 - Don't run MediaControlService on unsupported Android versions.

https://reviewboard.mozilla.org/r/237314/#review243394

I think I'd just roll this patch into the other one. The patch doesn't seem to match the commit message IMO.

Comment 4

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 8968621 [details]
Bug 1454709 - Part 2 - Don't start MediaControlService un unsupported OS versions in the first place.

https://reviewboard.mozilla.org/r/237316/#review243396

Comment 5

[Jan Henning [:JanH]]

Comment on attachment 8968620 [details]
Bug 1454709 - Don't run MediaControlService on unsupported Android versions.

https://reviewboard.mozilla.org/r/237314/#review243394

I sort of see why you might mean that, but just to explain things more precisely for the record:
- Without this patch, when the service is starting (because somebody sent a corresponding Intent) on an unsupported Android version, we return early from initialise, but never call `stopSelf()`, so the service nominally keeps on running, even though it won't be able to do anything interesting with `mInitialize` being false.
- With this patch, if anybody causes the service to start up, we not only just skip initialisation if the Android version is too low, but also shut the service down again by calling `stopSelf()` before returning from `onCreate()`.

Comment 6

[Jan Henning [:JanH]]

Comment on attachment 8968620 [details]
Bug 1454709 - Don't run MediaControlService on unsupported Android versions.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/237314/diff/1-2/

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/13f330a9dba1
Don't run MediaControlService on unsupported Android versions. r=snorp

Comment 8

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/13f330a9dba1