Closed Bug 1454763 Opened 6 years ago Closed 6 years ago

Filtered elements are clipped during off-main-thread animations

Categories

(Core :: Graphics: WebRender, defect, P1)

Product:
Core
Component:
Graphics: WebRender
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla61
Tracking Flags:
Tracking Status
firefox-esr52 --- unaffected
firefox-esr60 --- unaffected
firefox59 --- unaffected
firefox60 --- unaffected
firefox61 --- disabled

People

(Reporter: mstange, Assigned: gw)

References

Details

(Keywords: regression)

Attachments

(1 file)

testcase
561 bytes, text/html
Details
Attached file testcase — 
In this testcase, the rounded rectangle is sometimes not painted completely. Moving the mouse will trigger an update to the "clip".
Debian Testing, KDE, Radeon RX480, 2560x1440

(Without WebRender the bottom line is always flickering. Even on 2017-03-01.)

good = looks perfect.
mozregression --good 2018-03-20 --bad 2018-04-17 --pref gfx.webrender.all:true startup.homepage_welcome_url:'https://bugzilla.mozilla.org/attachment.cgi?id=8968651'
> 9:09.93 INFO: Last good revision: 48e344feb212edf648879380b877151fb4c29ec6
> 9:09.93 INFO: First bad revision: 0c721699dba5fdcf8d1fafe9aeb845532349bb59
> 9:09.93 INFO: Pushlog:
> https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=48e344feb212edf648879380b877151fb4c29ec6&tochange=0c721699dba5fdcf8d1fafe9aeb845532349bb59

> 0c721699dba5	Kartikaya Gupta — Bug 1419851 - Handle OMTA throttling for webrender. r=jrmuizel
Blocks: 1419851
Has Regression Range: --- → yes
Has STR: --- → yes
status-firefox59: --- → unaffected
status-firefox60: --- → unaffected
status-firefox61: affected → disabled
status-firefox-esr52: --- → unaffected
Keywords: regressionwindow-wanted → regression
The animation in comment 0 isn't running on the compositor on normal gecko.  That's odd.
That's because our non-WebRender compositors don't support filters, so we force filters + their contents to be painted on the main thread. (Bug 869496 wanted to fix this but it looks like it's going to be superseded by WebRender.)
Oh I see.  Thanks.  Confirmed the corresponding layer in question is a basic layer on non-WebRender.
try builds from bug 1454623:
> WR @ b360f8a057df4a30534ba84d31e82b5f8945d7db
mozregression --repo try --launch 028d207aab06759b2018d0e34b7730864f426006 --pref gfx.webrender.all:true startup.homepage_welcome_url:'https://bugzilla.mozilla.org/attachment.cgi?id=8968651'
last bad

> WR @ 4f323417a52ef59b27dae931b34f6f9c35b4de9c
mozregression --repo try --launch 447309e81be826b40d867056e2d924f882b4f10b --pref gfx.webrender.all:true startup.homepage_welcome_url:'https://bugzilla.mozilla.org/attachment.cgi?id=8968651'
first good
Assignee: nobody → gwatson
Status: NEW → ASSIGNED
Depends on: 1454623
See Also: → https://github.com/servo/webrender/pull/2669
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox-esr60: --- → unaffected
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: