1454781 - Show a warning in the devtools console when SameSite value is unrecognized

Status: RESOLVED FIXED

(Core :: Networking: Cookies, enhancement, P3)

Description

[François Marier [:francois]]

Right now, we silently ignore the SameSite cookie attribute if its value is anything other than `lax` or `strict`.

We should add an `else` clause and show a devtools console warning: https://searchfox.org/mozilla-central/rev/f65d7528e34ef1a7665b4a1a7b7cdb1388fcd3aa/netwerk/cookie/nsCookieService.cpp#4005

Comment 1

[Andrea Marchesini [:baku]]

Attachment: Bug 1454781 - SameSite policy logged in the console - part 1 - more data shown in MOZ_LOG, r?ehsan

Comment 2

[Andrea Marchesini [:baku]]

Attachment: Bug 1454781 - SameSite policy logged in the console - part 2 - Console messages, r?ehsan

Depends on D65241

Comment 3

[Andrea Marchesini [:baku]]

Attachment: Bug 1454781 - SameSite policy logged in the console - part 3 - report and flush console events, r?dragana

Depends on D65242

Comment 4

[Andrea Marchesini [:baku]]

Attachment: Bug 1454781 - SameSite policy logged in the console - part 4 - tests, r?ehsan

Comment 5

[Andrea Marchesini [:baku]]

Attachment: Bug 1454781 - SameSite policy logged in the console - part 3 - log invalid sameSite values, r?ehsan

Depends on D65243

Comment 6

[Phabricator Automation]

Comment on attachment 9130642 [details]
Bug 1454781 - SameSite policy logged in the console - part 3 - report and flush console events, r?dragana

Revision D65243 was moved to bug 1619971. Setting attachment 9130642 [details] to obsolete.

Comment 7

[Andrea Marchesini [:baku]]

Attachment: Bug 1454781 - SameSite policy logged in the console - part 5 - Console messages for beta, r?ehsan

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/538840a78b48
SameSite policy logged in the console - part 1 - more data shown in MOZ_LOG, r=Ehsan
https://hg.mozilla.org/integration/autoland/rev/b0a160275ad6
SameSite policy logged in the console - part 2 - Console messages, r=Ehsan
https://hg.mozilla.org/integration/autoland/rev/48192dbaa130
SameSite policy logged in the console - part 3 - log invalid sameSite values, r=Ehsan
https://hg.mozilla.org/integration/autoland/rev/8e8c6ec56d02
SameSite policy logged in the console - part 4 - tests, r=Ehsan
https://hg.mozilla.org/integration/autoland/rev/bd7e270da86d
SameSite policy logged in the console - part 5 - Console messages for beta, r=Ehsan

Comment 9

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/538840a78b48
https://hg.mozilla.org/mozilla-central/rev/b0a160275ad6
https://hg.mozilla.org/mozilla-central/rev/48192dbaa130
https://hg.mozilla.org/mozilla-central/rev/8e8c6ec56d02
https://hg.mozilla.org/mozilla-central/rev/bd7e270da86d