Closed Bug 1454831 Opened 2 years ago Closed 2 years ago

Consider generating nsCSSPropertyID.h from script rather than relying on preprocessing

Categories

(Core :: CSS Parsing and Computation, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: xidorn, Assigned: xidorn)

References

Details

Attachments

(1 file)

After bug 1452542, we have a property list generated from Servo side, and make nsCSSPropertyID.h use that file instead of nsCSSPropList.h.

But actually, we can probably do a step further to make it a file generated by script.

Since this is a widely included header, making it generated from script would allow us to avoid massive rebuild when we are touching information in property list unrelated to property name, e.g. prefs and flags.

Also it can help us get rid of the hacky enum constant trick (the dummy stuff), since we can generate the number directly.
Assignee: nobody → xidorn+moz
Actually, according to my experiment, it's not going to help the massive rebuild, because the modified time is updated regardless due to change in bug 1218999. (It's not clear to me, then, how does it make sense to use FileAvoidWrite at all for generated files...)
Comment on attachment 8968856 [details]
Bug 1454831 - Generate nsCSSPropertyID.h from data file directly.

https://reviewboard.mozilla.org/r/237576/#review243304

Looks good to me, thanks!
Attachment #8968856 - Flags: review?(emilio) → review+
Pushed by xquan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cc39f78a3d4e
Generate nsCSSPropertyID.h from data file directly. r=emilio
Pushed by xquan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/319ba32110ed
followup - Fix bustage on a CLOSED TREE.
https://hg.mozilla.org/mozilla-central/rev/cc39f78a3d4e
https://hg.mozilla.org/mozilla-central/rev/319ba32110ed
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.