1454931 - Application panel: show a help screen when there are no workers to display

Status: RESOLVED FIXED

(DevTools :: Application Panel, enhancement, P3)

Description

[Julian Descottes [:jdescottes]]

Split from Bug 1445197. We will land parts 1 to 4 from Bug 1445197 and will handle the help screen review in this bug.

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1454931 - Display help screen when no service worker is available;

Review commit: https://reviewboard.mozilla.org/r/237592/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/237592/

Comment 2

[Soledad Penades [:sole] [:spenades]]

Comment on attachment 8968877 [details]
Bug 1454931 - Display help screen when no service worker is available;

https://reviewboard.mozilla.org/r/237592/#review243324

I have concerns about the CSS style but that doesn't mean this cannot get landed :-)

Comment 3

[Julian Descottes [:jdescottes]]

Comment on attachment 8968877 [details]
Bug 1454931 - Display help screen when no service worker is available;

https://reviewboard.mozilla.org/r/237592/#review243324

Thanks for the review! As discussed on Slack, a follow up to harmonize our "empty/help" screens would be great. We have such screens in Netmonitor, Debugger, Memory and Performance tools. They all look and behave slightly different!

Comment 4

[Julian Descottes [:jdescottes]]

Comment on attachment 8968877 [details]
Bug 1454931 - Display help screen when no service worker is available;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/237592/diff/1-2/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e56c4c3f751f
Display help screen when no service worker is available;r=sole

Comment 6

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/e56c4c3f751f

Comment 7

[Patrick Brosset <:pbro>]

Mass move to the new application panel component.