1454985 - Highlight state for search provider in search bar should fill height of bar

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect, P2)

Description

[Amy Lee [:amylee] UX]

Attachment: Screen Shot 2018-04-18 at 11.06.02.png

Hi

The highlight state should fill up to the edges of the top/bottom hairlines. See screenshot. 

Thanks!

Comment 1

[Ricky Rosario [:rrosario, :r1cky]]

I think this is going to require changes to the drop down code (contentSearchUI.js in m-c). Unless, there is some clever css hack to do it from our end. Maybe using ::after for the border? hmm

Comment 2

[Ed Lee :Mardak]

Nod. We've used the ::after/::before for other borders in activity stream

Comment 3

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4107

Comment 4

[[github robot]]

Commits pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/97372beab416561c60594695adacbbb07b7c18aa
Fix Bug 1454985 - use ::after for search provider dividers

https://github.com/mozilla/activity-stream/commit/00cdff80c81dbfd2894d4232a105d9643cddc5d4
Merge pull request #4107 from rlr/Bug1454985/search-icon-border

Fix Bug 1454985 - use ::after for search provider dividers

Comment 6

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/5d2486077e4b

Comment 7

[[github robot]]

Commit pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/a15c074a2b22472c170c0c12bdca33e7444a749d
fix(styles): Switch to border-image instead of ::after for search engine separator (#4115)

Followup Bug 1454985 - Highlight state for search provider in search bar should fill height of bar

Comment 8

[Ciprian Muresan [:cmuresan], Formerly of Ecosystem QA - please needinfo @mcoman for things regarding the team]

Build ID 	20180422223305
User Agent 	Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:61.0) Gecko/20100101 Firefox/61.0

I have verified that the issue is no longer reproducible on the latest Nightly build on Windows 10 x64, Mac 10.13.3 and Arch Linux x64.