Closed Bug 1455050 Opened 6 years ago Closed 6 years ago

Don't include provider name for sponsored checkbox preference

Categories

(Firefox :: New Tab Page, enhancement, P1)

Product:
Firefox
Component:
New Tab Page
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 61
Iteration:
61.3 - Apr 23
Tracking Flags:
Tracking Status
firefox61 --- fixed

People

(Reporter: Mardak, Assigned: Mardak)

References

Details

(Whiteboard: [strings landed])

Bug 1404890 designs had "Pocket Sponsored Stories" whereas the previous sidebar preferences had "Show Sponsored Stories" but from the meeting, sounds like it was desired to be just "[✓] Sponsored Stories" We can avoid needing a new string translated if we just use the existing "[✓] Show Sponsored Stories"
Flags: needinfo?(abenson)
Aaron says "Show" is redundant, so we'll need new strings.
Flags: needinfo?(abenson)
Assignee: nobody → edilee
Iteration: --- → 61.3 - Apr 23
Priority: -- → P1
Commit pushed to master at https://github.com/mozilla/activity-stream https://github.com/mozilla/activity-stream/commit/86050a1c4d471d269a4cc6efd50400a6dc7f8b51 fix(prefs): Switch to new string for "Sponsored Stories" (#4108) Fix Bug 1455050 - Don't include provider name for sponsored checkbox preference
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Blocks: 1455216
https://hg.mozilla.org/mozilla-central/rev/5d2486077e4b
status-firefox61: --- → fixed
Target Milestone: --- → Firefox 61
Strings landed for localization in https://github.com/mozilla/activity-stream-l10n/pull/15
Whiteboard: [strings needed] → [strings landed]
Component: Activity Streams: Newtab → New Tab Page
You need to log in before you can comment on or make changes to this bug.