Closed
Bug 1455071
Opened 6 years ago
Closed 6 years ago
Structured clone refactoring
Categories
(Core :: JavaScript Engine, enhancement)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla61
Tracking | Status | |
---|---|---|
firefox61 | --- | fixed |
People
(Reporter: sfink, Assigned: sfink)
Details
Attachments
(6 files)
1.26 KB,
patch
|
sfink
:
review+
|
Details | Diff | Splinter Review |
18.93 KB,
patch
|
sfink
:
review+
|
Details | Diff | Splinter Review |
2.44 KB,
patch
|
sfink
:
review+
|
Details | Diff | Splinter Review |
1.74 KB,
patch
|
sfink
:
review+
|
Details | Diff | Splinter Review |
2.94 KB,
patch
|
sfink
:
review+
|
Details | Diff | Splinter Review |
29.55 KB,
patch
|
baku
:
review+
|
Details | Diff | Splinter Review |
Structured cloning has weird layering that is getting in the way of some changes I'd like to make.
Assignee | ||
Comment 1•6 years ago
|
||
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → sphink
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•6 years ago
|
||
Then move JSStructuredCloneWriter's callbacks, callback data, and refsHeld into its SCOutput's JSStructuredCloneData. This removes the loose fields from JSStructuredCloneWriter and allows using move construction to remove a bunch of code.
Assignee | ||
Comment 3•6 years ago
|
||
Assignee | ||
Comment 4•6 years ago
|
||
Assignee | ||
Comment 5•6 years ago
|
||
Assignee | ||
Comment 6•6 years ago
|
||
Assignee | ||
Comment 7•6 years ago
|
||
Comment on attachment 8969015 [details] [diff] [review] Allow synthetic clone buffers to contain transferables, Carrying over r=jorendorff on all these patches.
Attachment #8969015 -
Flags: review+
Assignee | ||
Updated•6 years ago
|
Attachment #8969016 -
Flags: review+
Assignee | ||
Updated•6 years ago
|
Attachment #8969017 -
Flags: review+
Assignee | ||
Updated•6 years ago
|
Attachment #8969018 -
Flags: review+
Assignee | ||
Updated•6 years ago
|
Attachment #8969019 -
Flags: review+
Assignee | ||
Updated•6 years ago
|
Attachment #8969020 -
Flags: review+
Assignee | ||
Comment 8•6 years ago
|
||
Comment on attachment 8969020 [details] [diff] [review] Use delegation rather than inheritance for the BufferList in JSStructuredCloneData, Review of attachment 8969020 [details] [diff] [review]: ----------------------------------------------------------------- Andrea, this is probably just a rubber stamp, but previously I only asked for (and received) feedback+ on this, so I'd like an r+ before landing. Thanks!
Attachment #8969020 -
Flags: review+ → review?(amarchesini)
Updated•6 years ago
|
Attachment #8969020 -
Flags: review?(amarchesini) → review+
Pushed by sfink@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/897e368bab8c Allow synthetic clone buffers to contain transferables, r=jorendorff https://hg.mozilla.org/integration/mozilla-inbound/rev/9f5ed3cd4d91 Bulk up SCOutput by changing it from storing a bare BufferList to a full JSStructuredCloneData, r=jorendorff https://hg.mozilla.org/integration/mozilla-inbound/rev/b932696b192a Remove unused alternate callback option to JSAutoStructuredCloneBuffer::clear, r=jorendorff https://hg.mozilla.org/integration/mozilla-inbound/rev/c544503c6ae6 Comment the purpose of JSAutoStructuredCloneBuffer, r=jorendorff https://hg.mozilla.org/integration/mozilla-inbound/rev/544004ece6c4 Remove unused JSAutoStructuredCloneBuffer::copy, r=jorendorff https://hg.mozilla.org/integration/mozilla-inbound/rev/482a42df57ac Use delegation rather than inheritance for the BufferList in JSStructuredCloneData, r=jorendorff,r=baku
Comment 10•6 years ago
|
||
Pushed by sfink@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/837f9a0480fb tier 2 bustage followup - s/WriteBytes/AppendBytes/
Comment 11•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/897e368bab8c https://hg.mozilla.org/mozilla-central/rev/9f5ed3cd4d91 https://hg.mozilla.org/mozilla-central/rev/b932696b192a https://hg.mozilla.org/mozilla-central/rev/c544503c6ae6 https://hg.mozilla.org/mozilla-central/rev/544004ece6c4 https://hg.mozilla.org/mozilla-central/rev/482a42df57ac https://hg.mozilla.org/mozilla-central/rev/837f9a0480fb
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in
before you can comment on or make changes to this bug.
Description
•