Closed Bug 1455127 Opened 6 years ago Closed 6 years ago

Remove dead features from upload.py

Categories

(Firefox Build System :: General, enhancement)

3 Branch
enhancement
Not set
normal

Tracking

(firefox61 fixed)

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: gps, Assigned: gps)

References

Details

Attachments

(3 files)

      No description provided.
Blocks: 1455143
Comment on attachment 8969094 [details]
Bug 1455127 - Remove functionality for uploading to a server;

https://reviewboard.mozilla.org/r/237784/#review243562

::: build/upload.py:55
(Diff revision 2)
>      optional full path that is a base path of the local file, construct the
>      full remote path to place the file in. If base_path is not None, include
>      the relative path from base_path to file."""
>      if base_path is None or not local_file.startswith(base_path):
>          # Hack to work around OSX uploading the i386 SDK from i386/dist. Both
>          # the i386 SDK and x86-64 SDK end up in the same directory this way.

I bet you could remove this too!

::: build/upload.py:90
(Diff revision 2)
> -    key = OptionalEnvironmentVariable('UPLOAD_SSH_KEY')
> -    post_upload_command = OptionalEnvironmentVariable('POST_UPLOAD_CMD')
>  
>      if sys.platform == 'win32':
>          if path is not None:
>              path = FixupMsysPath(path)

This whole block is no longer necessary, since `path` will always be a local path.

::: build/upload.py:99
(Diff revision 2)
>                        action="store",
>                        help="Preserve file paths relative to this path when uploading. "
>                        "If unset, all files will be uploaded directly to UPLOAD_PATH.")
>      parser.add_option("--properties-file",
> -                      action="store",
> +                      action = "store",
>                        help="Path to the properties file to store the upload properties.")

It looks like `--properties-file` only got used in the remote case, so I think you should just remove this as well.
Attachment #8969094 - Flags: review+
Attachment #8969094 - Flags: review?(core-build-config-reviews)
Comment on attachment 8969098 [details]
Bug 1455127 - Remove --properties-file from upload.py;

https://reviewboard.mozilla.org/r/237788/#review243564

Oh, oops, I commented on this in the previous patch.
Attachment #8969098 - Flags: review+
Attachment #8969098 - Flags: review?(core-build-config-reviews)
Attachment #8969099 - Flags: review?(core-build-config-reviews) → review?(ted)
Comment on attachment 8969099 [details]
Bug 1455127 - Remove --package from upload.py;

https://reviewboard.mozilla.org/r/237790/#review243566
Attachment #8969099 - Flags: review?(ted) → review+
Attachment #8969094 - Flags: review?(core-build-config-reviews)
Comment on attachment 8969094 [details]
Bug 1455127 - Remove functionality for uploading to a server;

https://reviewboard.mozilla.org/r/237784/#review243568
Attachment #8969094 - Flags: review+
Attachment #8969098 - Flags: review?(core-build-config-reviews)
Comment on attachment 8969098 [details]
Bug 1455127 - Remove --properties-file from upload.py;

https://reviewboard.mozilla.org/r/237788/#review243570
Attachment #8969098 - Flags: review+
Attachment #8969099 - Flags: review?(core-build-config-reviews)
Pushed by gszorc@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8c8fe0facf52
Remove functionality for uploading to a server; r=ted
https://hg.mozilla.org/integration/autoland/rev/8527e727b92d
Remove --properties-file from upload.py; r=ted
https://hg.mozilla.org/integration/autoland/rev/ac17015816ca
Remove --package from upload.py; r=ted
Pushed by gszorc@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/64ec147eb854
Remove functionality for uploading to a server; r=ted
https://hg.mozilla.org/integration/autoland/rev/ac6e19238b99
Remove --properties-file from upload.py; r=ted
https://hg.mozilla.org/integration/autoland/rev/339c87677421
Remove --package from upload.py; r=ted
I restored some functionality to the first patch that likely caused the regression and relanded. It appears to have stuck this time.
Flags: needinfo?(gps)
https://hg.mozilla.org/mozilla-central/rev/64ec147eb854
https://hg.mozilla.org/mozilla-central/rev/ac6e19238b99
https://hg.mozilla.org/mozilla-central/rev/339c87677421
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Version: Version 3 → 3 Branch
You need to log in before you can comment on or make changes to this bug.