Closed
Bug 1455127
Opened 6 years ago
Closed 6 years ago
Remove dead features from upload.py
Categories
(Firefox Build System :: General, enhancement)
Tracking
(firefox61 fixed)
RESOLVED
FIXED
mozilla61
Tracking | Status | |
---|---|---|
firefox61 | --- | fixed |
People
(Reporter: gps, Assigned: gps)
References
Details
Attachments
(3 files)
No description provided.
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 5•6 years ago
|
||
mozreview-review |
Comment on attachment 8969094 [details] Bug 1455127 - Remove functionality for uploading to a server; https://reviewboard.mozilla.org/r/237784/#review243562 ::: build/upload.py:55 (Diff revision 2) > optional full path that is a base path of the local file, construct the > full remote path to place the file in. If base_path is not None, include > the relative path from base_path to file.""" > if base_path is None or not local_file.startswith(base_path): > # Hack to work around OSX uploading the i386 SDK from i386/dist. Both > # the i386 SDK and x86-64 SDK end up in the same directory this way. I bet you could remove this too! ::: build/upload.py:90 (Diff revision 2) > - key = OptionalEnvironmentVariable('UPLOAD_SSH_KEY') > - post_upload_command = OptionalEnvironmentVariable('POST_UPLOAD_CMD') > > if sys.platform == 'win32': > if path is not None: > path = FixupMsysPath(path) This whole block is no longer necessary, since `path` will always be a local path. ::: build/upload.py:99 (Diff revision 2) > action="store", > help="Preserve file paths relative to this path when uploading. " > "If unset, all files will be uploaded directly to UPLOAD_PATH.") > parser.add_option("--properties-file", > - action="store", > + action = "store", > help="Path to the properties file to store the upload properties.") It looks like `--properties-file` only got used in the remote case, so I think you should just remove this as well.
Attachment #8969094 -
Flags: review+
Updated•6 years ago
|
Attachment #8969094 -
Flags: review?(core-build-config-reviews)
Comment 6•6 years ago
|
||
mozreview-review |
Comment on attachment 8969098 [details] Bug 1455127 - Remove --properties-file from upload.py; https://reviewboard.mozilla.org/r/237788/#review243564 Oh, oops, I commented on this in the previous patch.
Attachment #8969098 -
Flags: review+
Updated•6 years ago
|
Attachment #8969098 -
Flags: review?(core-build-config-reviews)
Updated•6 years ago
|
Attachment #8969099 -
Flags: review?(core-build-config-reviews) → review?(ted)
Comment 7•6 years ago
|
||
mozreview-review |
Comment on attachment 8969099 [details] Bug 1455127 - Remove --package from upload.py; https://reviewboard.mozilla.org/r/237790/#review243566
Attachment #8969099 -
Flags: review?(ted) → review+
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Updated•6 years ago
|
Attachment #8969094 -
Flags: review?(core-build-config-reviews)
Comment 11•6 years ago
|
||
mozreview-review |
Comment on attachment 8969094 [details] Bug 1455127 - Remove functionality for uploading to a server; https://reviewboard.mozilla.org/r/237784/#review243568
Attachment #8969094 -
Flags: review+
Updated•6 years ago
|
Attachment #8969098 -
Flags: review?(core-build-config-reviews)
Comment 12•6 years ago
|
||
mozreview-review |
Comment on attachment 8969098 [details] Bug 1455127 - Remove --properties-file from upload.py; https://reviewboard.mozilla.org/r/237788/#review243570
Attachment #8969098 -
Flags: review+
Updated•6 years ago
|
Attachment #8969099 -
Flags: review?(core-build-config-reviews)
Comment 13•6 years ago
|
||
mozreview-review |
Comment on attachment 8969099 [details] Bug 1455127 - Remove --package from upload.py; https://reviewboard.mozilla.org/r/237790/#review243572
Attachment #8969099 -
Flags: review+
Comment 14•6 years ago
|
||
Pushed by gszorc@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8c8fe0facf52 Remove functionality for uploading to a server; r=ted https://hg.mozilla.org/integration/autoland/rev/8527e727b92d Remove --properties-file from upload.py; r=ted https://hg.mozilla.org/integration/autoland/rev/ac17015816ca Remove --package from upload.py; r=ted
Comment 15•6 years ago
|
||
Backed out for messing with Windows 2012 build signing Push that started the failures (exceptions): https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=ac17015816ca21649f102f50038a20a81b03babe Failure log: https://taskcluster-artifacts.net/Z7lQV5LQTLmRAWLtTUNWOg/0/public/logs/chain_of_trust.log Backout: https://hg.mozilla.org/integration/autoland/rev/46ea55337b33a0c5aa7b2cc71848139e7976f293 From IRC: If you look at the artifacts of the upstream task: https://tools.taskcluster.net/groups/fVXyeZxTT0OORpuTWoZ2_w/tasks/Ml6GI0sGSlKr-09tTWf3rg/runs/0/artifacts vs that of a previous commit: https://tools.taskcluster.net/groups/ZnKgGdqXTT29wYwA_eZztA/tasks/SV2AbNmeTgCo6BnJZKytWw/runs/0/artifacts notice that the path of setup.exe is different. 5:34 AM And the error from https://taskcluster-artifacts.net/Z7lQV5LQTLmRAWLtTUNWOg/0/public/logs/chain_of_trust.log is about not finding setup.exe.
Flags: needinfo?(gps)
Comment 16•6 years ago
|
||
Pushed by gszorc@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/64ec147eb854 Remove functionality for uploading to a server; r=ted https://hg.mozilla.org/integration/autoland/rev/ac6e19238b99 Remove --properties-file from upload.py; r=ted https://hg.mozilla.org/integration/autoland/rev/339c87677421 Remove --package from upload.py; r=ted
Assignee | ||
Comment 17•6 years ago
|
||
I restored some functionality to the first patch that likely caused the regression and relanded. It appears to have stuck this time.
Flags: needinfo?(gps)
Comment 18•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/64ec147eb854 https://hg.mozilla.org/mozilla-central/rev/ac6e19238b99 https://hg.mozilla.org/mozilla-central/rev/339c87677421
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Updated•5 years ago
|
Version: Version 3 → 3 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•