Closed Bug 1455165 Opened 5 years ago Closed 5 years ago

Firefox lists external apps even if the network.protocol-handler.external-default is false


(Firefox for Android Graveyard :: General, defect)

Not set


(firefox61 fixed)

Firefox 61
Tracking Status
firefox61 --- fixed


(Reporter: igt0, Assigned: igt0)



(1 file)

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:59.0) Gecko/20100101 Firefox/59.0
Build ID: 20180326160923

Steps to reproduce:

1. go to about:config and set   network.protocol-handler.external-default to false
2. go to ​
3. Install zxing application
4. click and hold in any link in the page

Actual results:

Context menu allows the user to open an external app

Expected results:

External apps should not be shown in the context menu.
Flags: needinfo?(mark.finkle)
Attachment #8969138 - Flags: review?(bugzilla)
Flags: needinfo?(ntim.bugs)
Not sure what's being requested from me here, I don't work on Android.
Flags: needinfo?(ntim.bugs)
Flags: needinfo?(mark.finkle)
Attachment #8969138 - Flags: review?(bugzilla) → review?(michael.l.comella)
Comment on attachment 8969138 [details] [diff] [review]

Review of attachment 8969138 [details] [diff] [review]:

I tested this locally: this fixes the given STR. I'm not entirely certain what side effects it may have (e.g. where else is ExternalApps used?) but since it's an about:config object, I think it's safe to add.
Attachment #8969138 - Flags: review?(michael.l.comella) → review+
Here's a try push:

When everything is green (excepting the initial gecko decision task - I don't know why it failed), please add the "checkin-needed" keyword to get this checked in.
Flags: needinfo?(igt0)
Flags: needinfo?(igt0)
Keywords: checkin-needed
Pushed by
Filter external apps out if needed. r=mcomella
Keywords: checkin-needed
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.