14552 - MLK: GtkLayout structs get leaked.

Status: VERIFIED FIXED

(Core :: XUL, defect, P3)

Description

[Bruce Mitchener]

Happens several times during startup/view test 0/shutdown of viewer.

MLK: 40 bytes leaked at 0x90ac28
  * This memory was allocated from:
        malloc         [rtlib.o]
        calloc         [rtlib.o]
        g_malloc0      [gmem.c:242]
        gtk_type_new   [gtktypeutils.c:374]
        gtk_adjustment_new [gtkadjustment.c:119]
        gtk_layout_set_adjustments [gtklayout.c:159]
        gtk_layout_new [gtklayout.c:120]
        nsWindow::CreateNative(_GtkWidget*) [nsWindow.cpp:213]
        nsWidget::CreateWidget(nsIWidget*,const
nsRect&,nsEventStatus(*)(nsGUIEvent*),nsIDeviceContext*,nsIAppShell*,nsIToolkit*
,nsWidgetInitData*,void*) [nsWidget.cpp:844]
        nsWidget::Create(nsIWidget*,const
nsRect&,nsEventStatus(*)(nsGUIEvent*),nsIDeviceContext*,nsIAppShell*,nsIToolkit*
,nsWidgetInitData*) [nsWidget.cpp:924]
        nsView::CreateWidget(const nsID&,nsWidgetInitData*,void*,int)
[nsView.cpp:1233]
        nsScrollingView::CreateScrollControls(void*) [nsScrollingView.cpp:812]
        nsScrollFrame::CreateScrollingView(nsIPresContext&)
[nsScrollFrame.cpp:276]

nsScrollFrame::Init(nsIPresContext&,nsIContent*,nsIFrame*,nsIStyleContext*,nsIFr
ame*) [nsScrollFrame.cpp:84]

nsCSSFrameConstructor::ConstructRootFrame(nsIPresContext*,nsIContent*,nsIFrame*&
) [nsCSSFrameConstructor.cpp:2439]
        StyleSetImpl::ConstructRootFrame(nsIPresContext*,nsIContent*,nsIFrame*&)
[nsStyleSet.cpp:847]
        PresShell::InitialReflow(int,int) [nsPresShell.cpp:850]
        HTMLContentSink::StartLayout() [nsHTMLContentSink.cpp:2364]
        HTMLContentSink::OpenBody(const nsIParserNode&)
[nsHTMLContentSink.cpp:2013]
        CNavDTD::OpenBody(const nsIParserNode&) [CNavDTD.cpp:2324]
        CNavDTD::OpenContainer(const nsIParserNode&,int) [CNavDTD.cpp:2492]
        CNavDTD::HandleDefaultStartToken(CToken*,nsHTMLTag,nsIParserNode&)
[CNavDTD.cpp:1056]
        CNavDTD::HandleStartToken(CToken*) [CNavDTD.cpp:1308]
        NavDispatchTokenHandler(CToken*,nsIDTD*) [CNavDTD.cpp:241]
        CTokenHandler::operator ()(CToken*,nsIDTD*) [nsTokenHandler.cpp:80]
        CNavDTD::HandleToken(CToken*,nsIParser*) [CNavDTD.cpp:743]

CNavDTD::BuildModel(nsIParser*,nsITokenizer*,nsITokenObserver*,nsIContentSink*)
[CNavDTD.cpp:554]
        nsParser::BuildModel() [nsParser.cpp:972]
        nsParser::ResumeParse(nsIDTD*,int) [nsParser.cpp:910]

nsParser::OnDataAvailable(nsIChannel*,nsISupports*,nsIInputStream*,unsigned
int,unsigned int) [nsParser.cpp:1327]

Comment 1

[Peter Trudelle]

Putting on beta1 radar.

Comment 2

[Peter Trudelle]

pav, a 40 byte leak is not obviously a beta1 stopper, even if it happens hundreds 
of times. Please either explain why this needs to be fixed for beta, or move to 
M15 and remove from beta1 radar.

Comment 3

[Stuart Parmenter]

we don't use gtklayout's anymore.

Comment 4

[Claudius Gayle]

code level. marking VERIFIED.

Comment 5

[Pulsebot]

Pushed by ffxbld-merge:
https://hg.mozilla.org/releases/mozilla-beta/rev/efd77101ddbb
[fenix] For https://github.com/mozilla-mobile/fenix/issues/14552: Do not display back button when there is no tab history.