1455229 - Add Google Keep into the blacklist to use legacy keypress event behavior

Status: RESOLVED FIXED

(Core :: DOM: Events, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

STR:
1. Go to https://keep.google.com
2. Click the list icon next to "Take a note...".
3. Type something for label of first list item.
4. Type Enter.
5. Type something for label of second list item.
6. Try to move between list items with ArrowUp and ArrowDown keys.

Cannot move list items if in the strict keypress dispatching mode.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=cb791f9fcde3907b3395727076b979b2a825832f

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1455229 - Add keep.google.com into the blacklist to take back legacy keypress event behavior

With the strict keypress event dispatching mode, cannot navigate between
list items in keep.google.com.  So, until they fix this issue, we should
include keep.google.com into the blacklist for Nightly testers.

Review commit: https://reviewboard.mozilla.org/r/237974/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/237974/

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8969238 [details]
Bug 1455229 - Add keep.google.com into the blacklist to take back legacy keypress event behavior

https://reviewboard.mozilla.org/r/237974/#review244548

(I'd expect that we'll need to add pretty much all Google sites to the list before they fix their code)

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8969238 [details]
Bug 1455229 - Add keep.google.com into the blacklist to take back legacy keypress event behavior

https://reviewboard.mozilla.org/r/237974/#review244548

Yeah, but we will get a list for QA to ride on the train.

Comment 5

[Mozilla Autoland]

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 12c64f8d2ae4fa66c5a85f901ae957334d212c7b -d 983099e546d8: rebasing 459925:12c64f8d2ae4 "Bug 1455229 - Add keep.google.com into the blacklist to take back legacy keypress event behavior r=smaug" (tip)
merging modules/libpref/init/all.js
warning: conflicts while merging modules/libpref/init/all.js! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)

Comment 6

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8969238 [details]
Bug 1455229 - Add keep.google.com into the blacklist to take back legacy keypress event behavior

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/237974/diff/1-2/

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/87f19e952903
Add keep.google.com into the blacklist to take back legacy keypress event behavior r=smaug

Comment 8

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/87f19e952903

Comment 9

[Kohei Yoshino]

Updated the site compatibility note: https://www.fxsitecompat.com/en-CA/docs/2018/non-printable-keys-will-soon-stop-firing-keypress-event/