1455276 - Pass an `openLink` prop to Reps

Status: VERIFIED FIXED

(DevTools :: Accessibility Tools, defect)

Description

[Nicolas Chevobbe [:nchevobbe]]

The panel uses Reps, which automatically "linkify" links in strings.
But in order to be handled, we need to pass an `openLink` prop to Rep so it can actually open the link in a new tab (see https://searchfox.org/mozilla-central/source/devtools/client/webconsole/utils/object-inspector.js#67)

Comment 1

[Yura Zenevich [:yzen] (please use "needinfo")]

Attachment: 1455276 patch

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 8981473 [details] [diff] [review]
1455276 patch

Review of attachment 8981473 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good to me, thanks yura.
It would be nice to have a test to make sure it works as intended.
Also, we could handle Ctrl/Cmd + click to open tab in the background (see https://searchfox.org/mozilla-central/rev/5a744713370ec47969595e369fd5125f123e6d24/devtools/client/webconsole/hudservice.js#367-371)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9b53708a3203
ensure links in strings can open in Accessible properties. r=nchevobbe

Comment 4

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/9b53708a3203

Comment 5

[Yura Zenevich [:yzen] (please use "needinfo")]

Attachment: 1455276 updated patch

Carry over

Comment 6

[Yura Zenevich [:yzen] (please use "needinfo")]

Comment on attachment 8982210 [details] [diff] [review]
1455276 updated patch

[Feature/Bug causing the regression]: Not a regression, supports a11y inspector deliverable for Fx61
[User impact if declined]: Users won't be able to click links (and navigate to URLS) that are rendered in a11y inspector sidebar.
[Is this code covered by automated tests?]: Yes
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: N/A
[Is the change risky?]: No
[Why is the change risky/not risky?]: Only adds ability to click on links in a11y inspector sidebar by using existing functionality in Reps.js. Also covered by tests.
[String changes made/needed]: None

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8982210 [details] [diff] [review]
1455276 updated patch

a11y inspector improvement. Approved for 61.0b11.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/228c94554dc0

Comment 9

[Emil Ghitta, QA [:emilghitta]]

This issue is verified fixed using Firefox 62.0a1 (BuildId:20180604100129) and Firefox 61.0b11 (BuildId:20180604143143) on Windows 10 64bit, macOS 10.11.6 and Ubuntu 16.04 64bit.