1455283 - Create Entity Mixins to allow pontoon to re-use escaping code

Status: RESOLVED FIXED

(Localization Infrastructure and Tools :: compare-locales, enhancement)

Description

[Axel Hecht [:Pike]]

There's code that processes Entity.raw_val into .val, in particular for DTD and properties parser.

To run compare-locales checks in pontoon (or other tools), they need access to that logic, if they don't want to build the complete jazz of Parser.Context etc.

Let's move the logic to Mixins.

Comment 1

[Axel Hecht [:Pike]]

Attachment: compare-locales 3.1.1

Review commit: https://reviewboard.mozilla.org/r/237986/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/237986/

Comment 2

[Axel Hecht [:Pike]]

Attachment: Added tag RELEASE_3_1_1 for changeset 25052d96aca1

Review commit: https://reviewboard.mozilla.org/r/237988/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/237988/

Comment 3

[Axel Hecht [:Pike]]

Attachment: bug 1455283, create Mixins for Entity logic for dtd and properties,

Review commit: https://reviewboard.mozilla.org/r/237990/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/237990/

Comment 4

[Jarek Śmiejczak [:jotes]]

Comment on attachment 8969260 [details]
bug 1455283, create Mixins for Entity logic for dtd and properties,

https://reviewboard.mozilla.org/r/237990/#review243936

Hey, from my perspective this looks great - this patch simplifies integration with Pontoon (and makes it less "hacky").

Comment 5

[Axel Hecht [:Pike]]

Rebased and landed, https://hg.mozilla.org/l10n/compare-locales/rev/9e807c75fb6cb759d8b45cbb4b938defc01bf465.