1455294 - Add an option to toggle HTML comments in the inspector

Status: RESOLVED FIXED

(DevTools :: Inspector, enhancement, P3)

Description

[Patrick Brosset <:pbro>]

Attachment: toggle-comments-chrome.PNG

Chrome DevTools has this. It has also been requested here https://discourse.mozilla.org/t/show-hide-html-comments/23771/2.

The proposed feature is the following:
add a setting in the options panel (defaults to true) that controls whether HTML comment nodes are shown in the inspector.

Comment 1

[Nemanja C.]

I would like to work on this if there is no one else.

Comment 2

[Sebastian Zartner [:sebo]]

Nemanja, were you able to work on this?

Sebastian

Comment 3

[Patrick Brosset <:pbro>]

This bug has not been updated in the last 3 months. Resetting the assignee field.
Please, feel free to pick it up again and add a comment outlining your plans for it if you do still intend to work on it.
This is just trying to clean our backlog of bugs and make bugs available for people.

Comment 4

[Trishah]

I just wasted a lot of time trying to find a stray </div> that was screwing up a WordPress page. Without the comments showing in the view-source it meant I just had to trail-and-error it. Please add this functionality as it is a real problem that needs to be fixed. Thank you.

Comment 5

[Sebastian Zartner [:sebo]]

Attachment: Bug 1455294 - Added option to toggle the display of comment nodes within the Inspector. r=nchevobbe

Comment 9

[Sebastian Zartner [:sebo]]

Attachment: Bug 1455294 - Merged different tree walker filters into one using filter options. r=#devtools-reviewers

Comment 10

[Sebastian Zartner [:sebo]]

Attachment: Bug 1455294 - Added option to toggle the display of comment nodes in the Inspector. r=#devtools-reviewers

Depends on D186611

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/48d9c8dc7110
https://hg.mozilla.org/integration/autoland/rev/0237dd2b5eb9
Merged different tree walker filters into one using filter options. r=devtools-reviewers,nchevobbe
https://github.com/mozilla-firefox/firefox/commit/cf10bb950a42
https://hg.mozilla.org/integration/autoland/rev/f480cbd56b70
Added option to toggle the display of comment nodes in the Inspector. r=devtools-reviewers,fluent-reviewers,nchevobbe

Comment 13

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/0237dd2b5eb9
https://hg.mozilla.org/mozilla-central/rev/f480cbd56b70

Comment 14

[Ryan VanderMeulen [:RyanVM]]

Seems like this is worth a relnote callout. Please add a relnote-firefox? nomination to the bug if you agree!

Comment 15

[Sebastian Zartner [:sebo]]

Yep, wanted to do that today, anyway, but thanks for the ping!

[Why is this notable]: New DevTools feature
[Affects Firefox for Android]: no
[Suggested wording]: The DevTools now have an option to toggle the display of comment nodes in the Inspector. This option is located in the Settings panel.
[Links (documentation, blog post, etc)]:
https://firefox-source-docs.mozilla.org/devtools-user/settings/index.html#settings-inspector

Also added the dev-doc-needed flag, so it's added to the dev release notes for 152, as well.

Sebastian

Comment 16

[Ryan VanderMeulen [:RyanVM]]

Added to the Fx152 relnotes, thanks.

Comment 17

[Hamish Willee]

FF152 MDN docs work for this can be tracked in https://github.com/mdn/content/issues/44170 (just a release note)