1455302 - Allow scheduling updater thread tasks before the WR scene builder thread is up

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement, P1)

Description

[Kartikaya Gupta (email:[e-mail])]

Turns out there are legitimate scenarios where we get updater thread tasks (specifically UpdateZoomConstraints calls) before the WR scene builder thread is up and running. Currently we don't handle these properly, but it's actually not that hard to do, so we should do it.

This turned up during an automation run with async scene building enabled, but it can happen in production as well.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1455302 - Allow scheduling updater thread tasks before we have the updater thread id.

This is possible if we just let the APZUpdater know during construction
if WR is enabled or not, and that information combined with the pref
will allow it to know whether to use the scene builder thread task queue
or just use the compositor thread as the updater thread.

Review commit: https://reviewboard.mozilla.org/r/238028/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/238028/

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1455302 - Robustify the IsSamplerThread() check similarly to the updater code.

Same as the previous patch, but adapted for the sampler thread.

Review commit: https://reviewboard.mozilla.org/r/238030/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/238030/

Comment 3

[Botond Ballo [:botond]]

Comment on attachment 8969294 [details]
Bug 1455302 - Allow scheduling updater thread tasks before we have the updater thread id.

https://reviewboard.mozilla.org/r/238028/#review244234

Comment 4

[Botond Ballo [:botond]]

Comment on attachment 8969295 [details]
Bug 1455302 - Robustify the IsSamplerThread() check similarly to the updater code.

https://reviewboard.mozilla.org/r/238030/#review244236

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8450bccb1873
Allow scheduling updater thread tasks before we have the updater thread id. r=botond
https://hg.mozilla.org/integration/autoland/rev/9bb64b4e34ce
Robustify the IsSamplerThread() check similarly to the updater code. r=botond

Comment 6

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/8450bccb1873
https://hg.mozilla.org/mozilla-central/rev/9bb64b4e34ce