Closed Bug 1455302 Opened 6 years ago Closed 6 years ago

Allow scheduling updater thread tasks before the WR scene builder thread is up

Categories

(Core :: Graphics: WebRender, enhancement, P1)

Other Branch
enhancement

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: kats, Assigned: kats)

References

Details

(Whiteboard: [gfx-noted])

Attachments

(2 files)

Turns out there are legitimate scenarios where we get updater thread tasks (specifically UpdateZoomConstraints calls) before the WR scene builder thread is up and running. Currently we don't handle these properly, but it's actually not that hard to do, so we should do it.

This turned up during an automation run with async scene building enabled, but it can happen in production as well.
Comment on attachment 8969294 [details]
Bug 1455302 - Allow scheduling updater thread tasks before we have the updater thread id.

https://reviewboard.mozilla.org/r/238028/#review244234
Attachment #8969294 - Flags: review?(botond) → review+
Comment on attachment 8969295 [details]
Bug 1455302 - Robustify the IsSamplerThread() check similarly to the updater code.

https://reviewboard.mozilla.org/r/238030/#review244236
Attachment #8969295 - Flags: review?(botond) → review+
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8450bccb1873
Allow scheduling updater thread tasks before we have the updater thread id. r=botond
https://hg.mozilla.org/integration/autoland/rev/9bb64b4e34ce
Robustify the IsSamplerThread() check similarly to the updater code. r=botond
https://hg.mozilla.org/mozilla-central/rev/8450bccb1873
https://hg.mozilla.org/mozilla-central/rev/9bb64b4e34ce
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.