1455367 - [wpt-sync] Sync PR 10536 - Update fetch and service worker tests to allow same-origin redirects …

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 10536 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/w3c/web-platform-tests/pull/10536
Details from upstream follow.

Ben Kelly <[e-mail]> wrote:
>  Update fetch and service worker tests to allow same-origin redirects …
>  
>  …with no-cors requests.
>  
>  This attempts to align the initial test changes from #9039 with what finally landed in the spec.  It also fixes some thing like https-vs-http that crept into the fetch test in the last merge.
>  
>  @annevk @mattto @youennf

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=14c82266224375749b36e0580b24c5b1da728196

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=0518b3bc371f185a598c668b2e00b7a95584d52f

Comment 3

[Ben Kelly [:bkelly, not reviewing]]

James, now that bug 1455332 has landed can we get this merged?

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=522bb049f57614f2fe50cb48b8b25fc9496dda19

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=1dc55b950817f34545db1b0db75ce933a4570501

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Ran 3 tests and 176 subtests
OK     : 3
PASS   : 176

Comment 7

[Ben Kelly [:bkelly, not reviewing]]

Looks like its unstuck.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/372d779ec720
[wpt PR 10536] - Update fetch and service worker tests to allow same-origin redirects …, a=testonly

Comment 9

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/372d779ec720

Comment 10

[Ben Kelly [:bkelly, not reviewing]]

James, it appears that the wpt sync bot left a bunch of old expectations after this merged.  For example, redirect-mode.html.ini has:

  [Redirect 301 in follow redirect and cors mode]
    expected: FAIL

But that is no longer a test case since the test case name has "same-orign" or "cross-origin" added now.  Also, we pass all the tests in this file now.

Is this a known issue?

Comment 11

[James Graham [:jgraham]]

Yeah, we don't delete missing expectations because sometimes we get different tests on different configurations, so unless we have a full run of the testsuite across all supported configurations it's not possible to do safely. I will be working on the metadata update code soon, so this seems like a totally reasonable thing to add as an option.