Closed Bug 1455367 Opened 4 years ago Closed 3 years ago

[wpt-sync] Sync PR 10536 - Update fetch and service worker tests to allow same-origin redirects …

Categories

(Core :: DOM: Core & HTML, enhancement, P4)

enhancement

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 10536 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/w3c/web-platform-tests/pull/10536
Details from upstream follow.

Ben Kelly <ben@wanderview.com> wrote:
>  Update fetch and service worker tests to allow same-origin redirects …
>  
>  …with no-cors requests.
>  
>  This attempts to align the initial test changes from #9039 with what finally landed in the spec.  It also fixes some thing like https-vs-http that crept into the fetch test in the last merge.
>  
>  @annevk @mattto @youennf
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Component: web-platform-tests → DOM
Product: Testing → Core
James, now that bug 1455332 has landed can we get this merged?
Flags: needinfo?(james)
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Ran 3 tests and 176 subtests
OK     : 3
PASS   : 176
Looks like its unstuck.
Flags: needinfo?(james)
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/372d779ec720
[wpt PR 10536] - Update fetch and service worker tests to allow same-origin redirects …, a=testonly
https://hg.mozilla.org/mozilla-central/rev/372d779ec720
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
James, it appears that the wpt sync bot left a bunch of old expectations after this merged.  For example, redirect-mode.html.ini has:

  [Redirect 301 in follow redirect and cors mode]
    expected: FAIL

But that is no longer a test case since the test case name has "same-orign" or "cross-origin" added now.  Also, we pass all the tests in this file now.

Is this a known issue?
Flags: needinfo?(james)
Yeah, we don't delete missing expectations because sometimes we get different tests on different configurations, so unless we have a full run of the testsuite across all supported configurations it's not possible to do safely. I will be working on the metadata update code soon, so this seems like a totally reasonable thing to add as an option.
Flags: needinfo?(james)
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.